Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added DOTA2 dataset #1999

Merged
merged 10 commits into from
May 23, 2024
Merged

Added DOTA2 dataset #1999

merged 10 commits into from
May 23, 2024

Conversation

BloodAxe
Copy link
Contributor

@BloodAxe BloodAxe commented May 21, 2024 •
edited
Loading

This PR adds

  • DOTA2 dataset implementation
  • Script to prepare dataset files.
  • Metric implementation (mAP for rotated boxes)

shaydeci
shaydeci suggested changes May 22, 2024
View reviewed changes
Copy link
Contributor

@shaydeci shaydeci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some initial comments - inline.
Also, we are missing some tests...

src/super_gradients/training/datasets/obb/dota.py Outdated Show resolved Hide resolved
src/super_gradients/training/datasets/obb/dota.py Show resolved Hide resolved
src/super_gradients/training/metrics/obb_detection_metrics.py Show resolved Hide resolved
src/super_gradients/examples/dota_prepare_dataset/dota_prepare_dataset.py Show resolved Hide resolved
src/super_gradients/training/datasets/obb/collate.py Show resolved Hide resolved
src/super_gradients/training/datasets/obb/dota.py Show resolved Hide resolved
shaydeci
shaydeci approved these changes May 23, 2024
View reviewed changes
Copy link
Contributor

@shaydeci shaydeci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@BloodAxe BloodAxe merged commit a39e5c3 into feature/SG-1488-YoloNAS-R-integration May 23, 2024
4 checks passed
@BloodAxe BloodAxe deleted the feature/SG-1488-YoloNAS-R-integration-dota-dataset branch May 23, 2024 12:27
@BloodAxe BloodAxe mentioned this pull request Jun 4, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shaydeci shaydeci shaydeci approved these changes

@ofrimasad ofrimasad Awaiting requested review from ofrimasad ofrimasad is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@BloodAxe @shaydeci