Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update requirements.txt #417

Merged
merged 3 commits into from
Oct 13, 2022
Merged

Conversation

tomerkeren42
Copy link
Contributor

Pillow version was upgraded from 6.2.0 to 9.2.0, because of following bug was found while using pillow 8.2.0: Using transformations of random scale, which can be lower than expected crop-size, and then pad short size could lead to a bug in pillow version of padding - it was using a drawing rectangle (of zeros) instead of new method in newer versions. This method could create the following bug:
self.draw.draw_rectangle(xy, ink, 0, width)
TypeError: an integer is required (got type tuple)

Pillow version was upgraded from 6.2.0 to 9.2.0, because of following bug was found while using pillow 8.2.0:
Using transformations of random scale, which can be lower than expected crop-size, and then pad short size could lead to a bug in pillow version of padding - it was using a drawing rectangle (of zeros) instead of new method in newer versions. This method could create the following bug:
    self.draw.draw_rectangle(xy, ink, 0, width)
TypeError: an integer is required (got type tuple)
@dagshub
Copy link

dagshub bot commented Oct 3, 2022

Copy link
Contributor

@shaydeci shaydeci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ofrimasad ofrimasad merged commit 8fb8f74 into master Oct 13, 2022
@ofrimasad ofrimasad deleted the bugfix/SG-000_pillow_version_update branch October 13, 2022 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants