Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/sg 456 centralize ddp setup #544

Merged
merged 38 commits into from
Jan 5, 2023
Merged

Feature/sg 456 centralize ddp setup #544

merged 38 commits into from
Jan 5, 2023

Conversation

Louis-Dupont
Copy link
Contributor

@Louis-Dupont Louis-Dupont commented Dec 5, 2022 •
edited
Loading

Motivation:

  • Setup DDP in a single place
  • Setup DDP sooner to reduce risk of errors (when using an object that requires DDP before DDP is sertup)
  • Improving the logic and clarity of how DDP is setup

@dagshub
Copy link

dagshub bot commented Dec 5, 2022

Join the discussion on DagsHub!

@Louis-Dupont Louis-Dupont marked this pull request as ready for review December 13, 2022 14:05
@Louis-Dupont Louis-Dupont force-pushed the feature/SG-456-centralise_ddp_setup branch from 6908a69 to cc94d8e Compare December 26, 2022 09:17
shaydeci
shaydeci suggested changes Jan 1, 2023
View reviewed changes
Copy link
Contributor

@shaydeci shaydeci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, 1 short comment inline.
Please also run the gpu tests before we merge, so we won't have surprises on release.

shaydeci
shaydeci previously approved these changes Jan 4, 2023
View reviewed changes
Copy link
Contributor

@shaydeci shaydeci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shaydeci shaydeci merged commit f50d438 into master Jan 5, 2023
@shaydeci shaydeci deleted the feature/SG-456-centralise_ddp_setup branch January 5, 2023 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BloodAxe BloodAxe BloodAxe left review comments

@shaydeci shaydeci shaydeci approved these changes

@ofrimasad ofrimasad Awaiting requested review from ofrimasad ofrimasad is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Louis-Dupont @BloodAxe @shaydeci