Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PLFM-3331 Register experiments with model name #585

Merged
merged 3 commits into from
Dec 28, 2022
Merged

PLFM-3331 Register experiments with model name #585

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a56b590
PLFM-3331 Register experiments with model name
roikoren755 Dec 21, 2022
983ee25
PLFM-3331 Fix black
roikoren755 Dec 21, 2022
11aca3c
Merge branch 'master' into feature/plfm-3331_model_name_in_experiment
roikoren755 Dec 26, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions requirements.pro.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
deci-lab-client==3.1.1
deci-common==3.5.0
deci-lab-client==4.8.0
deci-common==3.15.0
10 changes: 9 additions & 1 deletion src/super_gradients/common/sg_loggers/deci_platform_sg_logger.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
import os
from typing import Optional

from super_gradients.common.abstractions.abstract_logger import get_logger
from super_gradients.common.sg_loggers.base_sg_logger import BaseSGLogger
Expand Down Expand Up @@ -36,6 +37,7 @@ def __init__(
save_tensorboard_remote: bool = True,
save_logs_remote: bool = True,
monitor_system: bool = True,
model_name: Optional[str] = None,
):

if _imported_deci_lab_failure is not None:
Expand All @@ -59,7 +61,13 @@ def __init__(

self.platform_client = DeciPlatformClient()
self.platform_client.login(token=os.getenv("DECI_PLATFORM_TOKEN"))
self.platform_client.register_experiment(name=experiment_name)
if model_name is None:
logger.warning(
"'model_name' parameter not passed. "
"The experiment won't be connected to an architecture in the Deci platform. "
"To pass a model_name, please use the 'sg_logger_params.model_name' field in the training recipe."
)
self.platform_client.register_experiment(name=experiment_name, model_name=model_name if model_name else None)
self.checkpoints_dir_path = checkpoints_dir_path

@multi_process_safe
Expand Down