Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/sg 132 models convert #598

Merged
merged 18 commits into from
Jan 8, 2023
Merged

Conversation

shaydeci
Copy link
Contributor

@shaydeci shaydeci commented Jan 4, 2023

  • Added models.convert_to_onnx.
  • Added conversion_params + convert_recipe example.
  • In order to verify the conversion script works- I also added ontop of the train_from_recipe (i.e gpu test) integration test a call to convert_recipe, then in the recipe tests I'm verifying the onnx file does exist.
  • Smal fix in cifar10 yaml (dient have multi_gpu mode).
  • Standarize transform (because we don't have ToTensor..it works on np arrays).

@dagshub
Copy link

dagshub bot commented Jan 4, 2023

@shaydeci shaydeci marked this pull request as ready for review January 4, 2023 12:14
@shaydeci shaydeci requested a review from ofrimasad as a code owner January 4, 2023 12:14
Copy link
Collaborator

@ofrimasad ofrimasad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

my comments inline

ofrimasad
ofrimasad previously approved these changes Jan 5, 2023
Copy link
Collaborator

@ofrimasad ofrimasad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@ofrimasad ofrimasad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ofrimasad ofrimasad merged commit e64b5f7 into master Jan 8, 2023
@ofrimasad ofrimasad deleted the feature/SG-132_models_convert branch January 8, 2023 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants