-
Notifications
You must be signed in to change notification settings - Fork 517
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/sg 132 models convert #598
Conversation
shaydeci
commented
Jan 4, 2023
•
edited
Loading
edited
- Added models.convert_to_onnx.
- Added conversion_params + convert_recipe example.
- In order to verify the conversion script works- I also added ontop of the train_from_recipe (i.e gpu test) integration test a call to convert_recipe, then in the recipe tests I'm verifying the onnx file does exist.
- Smal fix in cifar10 yaml (dient have multi_gpu mode).
- Standarize transform (because we don't have ToTensor..it works on np arrays).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
my comments inline
src/super_gradients/recipes/conversion_params/cifar10_conversion_params.yaml
Outdated
Show resolved
Hide resolved
src/super_gradients/recipes/conversion_params/cifar10_conversion_params.yaml
Outdated
Show resolved
Hide resolved
src/super_gradients/recipes/conversion_params/cifar10_conversion_params.yaml
Outdated
Show resolved
Hide resolved
src/super_gradients/recipes/conversion_params/default_conversion_params.yaml
Show resolved
Hide resolved
src/super_gradients/recipes/conversion_params/default_conversion_params.yaml
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM