-
Notifications
You must be signed in to change notification settings - Fork 530
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support 1.13 #603
Support 1.13 #603
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
my comment inline. can we make
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we set it to 1.13.*?
* New callbacks API * New callbacks API * New callbacks API * Fix imports * Uncomment sanity check * Fix callbacks order * Fix callbacks order * Fix callbacks order * Fix wrong import * Fix wrong import * Call update_context * Call update_context * Fix on_train_batch_start timing * Added docs clarifying mapping of new events to old Phase enum values * Instantiate context after _prep_for_test Co-authored-by: Shay Aharon <80472096+shaydeci@users.noreply.github.com>
Co-authored-by: Shay Aharon <80472096+shaydeci@users.noreply.github.com>
* first version - a few things to change * improve * imrpove doc * undo requirements change * mini update * support wildcards and improve code * move all to same file, and only raise error when version too small * move all to same file, and only raise error when version too small * remove arg
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
No description provided.