Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/sg 493 modelnames instead of strings #614

Merged
merged 15 commits into from
Jan 23, 2023

Conversation

shaydeci
Copy link
Contributor

No description provided.

Verified

This commit was signed with the committer’s verified signature.
ofrimasad Ofri Masad

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
…lnames_instead_of_strings
…lnames_instead_of_strings

# Conflicts:
#	src/super_gradients/examples/quantization/resnet_qat_example.py
#	tests/integration_tests/ema_train_integration_test.py
#	tests/integration_tests/pretrained_models_test.py
#	tests/unit_tests/detection_utils_test.py
#	tests/unit_tests/kd_ema_test.py
#	tests/unit_tests/kd_trainer_test.py
#	tests/unit_tests/pretrained_models_unit_test.py
#	tests/unit_tests/quantization_utility_tests.py
#	tests/unit_tests/test_without_train_test.py
#	tests/unit_tests/vit_unit_test.py
…lnames_instead_of_strings

# Conflicts:
#	.circleci/config.yml
@dagshub
Copy link

dagshub bot commented Jan 11, 2023

shaydeci and others added 3 commits January 18, 2023 11:15
…lnames_instead_of_strings

# Conflicts:
#	tests/unit_tests/dataset_statistics_test.py
#	tests/unit_tests/initialize_with_dataloaders_test.py
#	tests/unit_tests/loss_loggings_test.py
#	tests/unit_tests/train_with_intialized_param_args_test.py
…d_of_strings' into feature/SG-493_modelnames_instead_of_strings
@shaydeci shaydeci marked this pull request as ready for review January 22, 2023 13:26
@shaydeci shaydeci requested a review from ofrimasad as a code owner January 22, 2023 13:26
Copy link
Collaborator

@ofrimasad ofrimasad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one minor comment

Copy link
Collaborator

@ofrimasad ofrimasad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ofrimasad ofrimasad merged commit 1f6a183 into master Jan 23, 2023
@ofrimasad ofrimasad deleted the feature/SG-493_modelnames_instead_of_strings branch January 23, 2023 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants