Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed id_tensor registry, so reparametrization works when .cuda() is called #632

Merged
merged 3 commits into from
Jan 22, 2023
Merged

Fixed id_tensor registry, so reparametrization works when .cuda() is called #632

merged 3 commits into from
Jan 22, 2023

Conversation

spsancti
Copy link
Contributor

…called on the module

@dagshub
Copy link

dagshub bot commented Jan 17, 2023

Join the discussion on DagsHub!

ofrimasad
ofrimasad reviewed Jan 18, 2023
View reviewed changes
Copy link
Collaborator

@ofrimasad ofrimasad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor comment

src/super_gradients/modules/qarepvgg_block.py Show resolved Hide resolved
@spsancti spsancti requested a review from ofrimasad January 22, 2023 09:26
ofrimasad
ofrimasad approved these changes Jan 22, 2023
View reviewed changes
Copy link
Collaborator

@ofrimasad ofrimasad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ofrimasad ofrimasad merged commit 39a8dd3 into master Jan 22, 2023
@ofrimasad ofrimasad deleted the fix/qarepvgg-register-parameters branch January 22, 2023 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ofrimasad ofrimasad ofrimasad approved these changes

@shaydeci shaydeci Awaiting requested review from shaydeci

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@spsancti @ofrimasad