Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Losses.md docs #658

Merged
merged 7 commits into from
Jan 29, 2023
Merged

Losses.md docs #658

merged 7 commits into from
Jan 29, 2023

Conversation

shaydeci
Copy link
Contributor

No description provided.

@dagshub
Copy link

dagshub bot commented Jan 26, 2023

@shaydeci shaydeci marked this pull request as ready for review January 26, 2023 15:31
@shaydeci shaydeci requested a review from ofrimasad as a code owner January 26, 2023 15:31
@shaydeci shaydeci changed the title final version Losses.md docs Jan 26, 2023
Copy link
Collaborator

@ofrimasad ofrimasad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks very nice.
my comment inline

documentation/assets/Losses.md Outdated Show resolved Hide resolved
documentation/assets/Losses.md Outdated Show resolved Hide resolved
documentation/assets/Losses.md Outdated Show resolved Hide resolved
documentation/assets/Losses.md Outdated Show resolved Hide resolved
documentation/assets/Losses.md Outdated Show resolved Hide resolved
documentation/assets/Losses.md Show resolved Hide resolved
documentation/assets/Losses.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@ofrimasad ofrimasad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shaydeci shaydeci merged commit 64d0f78 into master Jan 29, 2023
@shaydeci shaydeci deleted the feature/SG-599_losses_docs branch January 29, 2023 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants