Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hotfix/sg 645 regression tests essential fixes #669

Merged
merged 6 commits into from
Jan 30, 2023
Merged

Hotfix/sg 645 regression tests essential fixes #669

merged 6 commits into from
Jan 30, 2023

Conversation

shaydeci
Copy link
Contributor

  • Ckpt_root_dir for recipes missing it.
  • Warning instead of exception for max_train_batchs/max_valid_batches greater than Len(DataLoader).
  • Limit max_batches to avoid timeout.
  • super_gradients.version update

@dagshub
Copy link

dagshub bot commented Jan 30, 2023

Join the discussion on DagsHub!

@shaydeci shaydeci marked this pull request as ready for review January 30, 2023 14:39
@shaydeci shaydeci requested a review from ofrimasad as a code owner January 30, 2023 14:39
ofrimasad
ofrimasad approved these changes Jan 30, 2023
View reviewed changes
Copy link
Collaborator

@ofrimasad ofrimasad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shaydeci shaydeci merged commit e32da15 into master Jan 30, 2023
@shaydeci shaydeci deleted the hotfix/SG-645_limit_tests_forward_passes branch January 30, 2023 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ofrimasad ofrimasad ofrimasad approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shaydeci @ofrimasad