Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug/sg 000 fix lr function scheduling and add deprecation #675

Merged
merged 5 commits into from
Jan 31, 2023
+3 −1
Merged

Bug/sg 000 fix lr function scheduling and add deprecation #675

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
1e26396
deprecation of functionlrrcallback + quick fix
shaydeci Jan 31, 2023
7588ab1
fix deprecated version
shaydeci Jan 31, 2023
72ad17e
Merge branch 'master' into bug/SG-000_fix_lr_function_scheduling_and_…
shaydeci Jan 31, 2023
a9d5f79
deprecation removed-in-version moved to major
shaydeci Jan 31, 2023
8f0e592
Merge remote-tracking branch 'origin/bug/SG-000_fix_lr_function_sched…
shaydeci Jan 31, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/super_gradients/training/utils/callbacks/callbacks.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@
import onnx
import onnxruntime
import torch
from deprecate import deprecated

from super_gradients.common.abstractions.abstract_logger import get_logger
from super_gradients.training.utils.callbacks.base_callbacks import PhaseCallback, PhaseContext, Phase, Callback
Expand Down Expand Up @@ -470,9 +471,10 @@ class FunctionLRCallback(LRCallbackBase):
Hard coded rate scheduling for user defined lr scheduling function.
"""

@deprecated(target=None, deprecated_in="3.6.0", remove_in="4.0.0")
def __init__(self, max_epochs, lr_schedule_function, **kwargs):
super(FunctionLRCallback, self).__init__(Phase.TRAIN_BATCH_STEP, **kwargs)
assert callable(self.lr_schedule_function), "self.lr_function must be callable"
assert callable(lr_schedule_function), "self.lr_function must be callable"
self.lr_schedule_function = lr_schedule_function
self.max_epochs = max_epochs

Expand Down