Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/sg 747 add preprocessing #804

Merged
merged 41 commits into from
Apr 3, 2023

Conversation

Louis-Dupont
Copy link
Contributor

@Louis-Dupont Louis-Dupont commented Mar 28, 2023

The way the processing classes work is that they support processing of image and post processing of predictions, which is all that is required in inference.

@dagshub
Copy link

dagshub bot commented Mar 28, 2023

@Louis-Dupont Louis-Dupont marked this pull request as ready for review March 29, 2023 08:04
Copy link
Contributor

@BloodAxe BloodAxe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Louis-Dupont Louis-Dupont merged commit 8774c2f into master Apr 3, 2023
@Louis-Dupont Louis-Dupont deleted the feature/SG-747-add_preprocessing branch April 3, 2023 09:45
Louis-Dupont added a commit that referenced this pull request Apr 17, 2023
* wip

* move to imageprocessors

* wip

* add back changes

* making it work fully for yolox and almost for ppyoloe

* minor change

* working for det

* cleaning

* clean

* undo

* replace empty with none

* add _get_shift_params

* minor doc change

* replace pydantic with dataclasses and fix typing

* add docstrings

* doc improvment and use get_shift_params in transforms

* add tests

* improve comment

* rename

* add option to keep ratio in rescale

* make functions private

* remove DetectionPaddedRescale

* fix doc

* add fixes

* improve _get_center_padding_params output

* minor fix

* add empty bbox test for rescale_bboxes

* finalizing _DetectionPadding, DetectionCenterPadding and DetectionBottomRightPadding

* remove _pad_to_side

* split rescale into 2 classes

* minor addition

* Add DetectionPrediction object

* simplify DetectionPrediction class

* add round and don't rescale if no change required

---------

Co-authored-by: Eugene Khvedchenya <ekhvedchenya@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants