-
Notifications
You must be signed in to change notification settings - Fork 517
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/sg 747 add preprocessing #804
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Louis-Dupont
requested review from
shaydeci,
ofrimasad and
BloodAxe
as code owners
March 29, 2023 08:04
BloodAxe
reviewed
Mar 29, 2023
BloodAxe
reviewed
Mar 30, 2023
BloodAxe
reviewed
Mar 30, 2023
BloodAxe
reviewed
Mar 30, 2023
BloodAxe
reviewed
Mar 30, 2023
BloodAxe
reviewed
Mar 30, 2023
BloodAxe
reviewed
Mar 30, 2023
BloodAxe
reviewed
Mar 30, 2023
BloodAxe
reviewed
Apr 3, 2023
BloodAxe
reviewed
Apr 3, 2023
BloodAxe
reviewed
Apr 3, 2023
BloodAxe
reviewed
Apr 3, 2023
BloodAxe
reviewed
Apr 3, 2023
BloodAxe
approved these changes
Apr 3, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Louis-Dupont
added a commit
that referenced
this pull request
Apr 17, 2023
* wip * move to imageprocessors * wip * add back changes * making it work fully for yolox and almost for ppyoloe * minor change * working for det * cleaning * clean * undo * replace empty with none * add _get_shift_params * minor doc change * replace pydantic with dataclasses and fix typing * add docstrings * doc improvment and use get_shift_params in transforms * add tests * improve comment * rename * add option to keep ratio in rescale * make functions private * remove DetectionPaddedRescale * fix doc * add fixes * improve _get_center_padding_params output * minor fix * add empty bbox test for rescale_bboxes * finalizing _DetectionPadding, DetectionCenterPadding and DetectionBottomRightPadding * remove _pad_to_side * split rescale into 2 classes * minor addition * Add DetectionPrediction object * simplify DetectionPrediction class * add round and don't rescale if no change required --------- Co-authored-by: Eugene Khvedchenya <ekhvedchenya@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The way the processing classes work is that they support processing of image and post processing of predictions, which is all that is required in inference.