-
Notifications
You must be signed in to change notification settings - Fork 517
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support single output in YoloX nms #813
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lkdci
requested review from
shaydeci,
ofrimasad,
BloodAxe and
Louis-Dupont
as code owners
April 2, 2023 07:55
BloodAxe
reviewed
Apr 2, 2023
src/super_gradients/training/models/detection_models/yolo_base.py
Outdated
Show resolved
Hide resolved
BloodAxe
reviewed
Apr 2, 2023
…nto feature/ALG-1294_yolox_nms_single_pred � Conflicts: � src/super_gradients/training/models/detection_models/yolo_base.py
@BloodAxe Added unit tests with yolox output and mock model outputs. I will appreciate your re-review |
…nto feature/ALG-1294_yolox_nms_single_pred
…nto feature/ALG-1294_yolox_nms_single_pred � Conflicts: � tests/deci_core_unit_test_suite_runner.py
ofrimasad
previously approved these changes
Jul 5, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
ofrimasad
approved these changes
Jul 5, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.