Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update of PoseEstimation model #872

Merged
merged 82 commits into from
May 4, 2023
Merged

Update of PoseEstimation model #872

merged 82 commits into from
May 4, 2023

Conversation

BloodAxe
Copy link
Contributor

@BloodAxe BloodAxe commented May 1, 2023

  • New model weights
  • Recipe to train DEKR-W32-NO-DC
  • Documentation
  • Rescoring
  • FlipTTA

BloodAxe added 30 commits April 12, 2023 10:38
@BloodAxe
Rescoring net
a9ad6ae
@BloodAxe
Added docs
11c3e3f
@BloodAxe
Added docs
c3374be
@BloodAxe
Tune recipe
78f0000
@BloodAxe
Reduce bs for validation loader
2e94101
@BloodAxe
Reduce bs for validation loader
cee3b0c
@BloodAxe
Do not store predictions on GPU
95da0fa
@BloodAxe
Do not store predictions on GPU
cd33fe0
@BloodAxe
Do not store predictions on GPU
ada17b6
@BloodAxe
Added ImageKeypointMatchingResult dataclass as return value for compu…
8507ca7 
…te_img_keypoint_matching
@BloodAxe
Script to generate trianing data (WIP)
e24c74b
@BloodAxe
Do not store predictions on GPU
54c2d5b
@BloodAxe
Lower LR
642ba9c
@BloodAxe
Merge remote-tracking branch 'origin/feature/SG-707-rescoring-net' in…
b7b11d2 
…to feature/SG-707-rescoring-net
@BloodAxe
Merge branch 'master' into feature/SG-707-rescoring-net
86034c8
@BloodAxe
Added check to ensure that person area is positive
602b8a0
@BloodAxe
Added check to ensure that person area is positive
37cedd0
@BloodAxe
Save all samples to enable us computing mAP score during rescore mode…
a605817 
…l training
@BloodAxe
Save all samples to enable us computing mAP score during rescore mode…
e55b94b 
…l training
@BloodAxe
Fix edge case when no predictions are made
16a1daf
@BloodAxe
Rescoring training
64033a5
@BloodAxe
Fix convert_to_tensor
1b98bce
@BloodAxe
High LR config
1b081ec
@BloodAxe
Disable ema
f5670f2
@BloodAxe
Merge branch 'master' into feature/SG-707-rescoring-net
58de569 
# Conflicts:
#	src/super_gradients/common/object_names.py
#	src/super_gradients/recipes/coco2017_pose_dekr_w32_no_dc.yaml
@BloodAxe
Fix rescoring training
0c6010b
@BloodAxe
Recipe for DDRNet39
8cdc0f0
@BloodAxe
Recipe for DDRNet39
3df3372
@BloodAxe
Recipe for DEKR with QFL
5702b7b
@BloodAxe
Preprocessing script to save data on train dataset
414af0a
@BloodAxe BloodAxe requested a review from Louis-Dupont as a code owner May 1, 2023 10:23
shaydeci
shaydeci suggested changes May 1, 2023
View reviewed changes
Copy link
Contributor

@shaydeci shaydeci left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!
Just 2 tiny comments in the docs, see inline.
Then LGTM on my end.

documentation/source/PoseEstimation.md Show resolved Hide resolved
documentation/source/PoseEstimation.md Outdated Show resolved Hide resolved
BloodAxe added 24 commits May 1, 2023 16:10
@BloodAxe
Fix typo in script -> scripts
4dd1bbf
@BloodAxe
Changed implementation of pose_nms to return empty arrays of shape 0,…
c030d3f 
…17,3
@BloodAxe
Rename integration test file for pose estimation
63a9dcc
@BloodAxe
Rename integration test file for pose estimation
f9aea7b
@BloodAxe
Rename integration test file for pose estimation
84c7799
@BloodAxe
Rename integration test file for pose estimation
6ea8486
@BloodAxe
Rename integration test file for pose estimation
49ed049
@BloodAxe
Update script config to generate rescoring training data
dcfc6ee
@BloodAxe
Update script config to generate rescoring training data
9960f1e
@BloodAxe
Merge branch 'master' into feature/SG-707-rescoring-net
b3c778d
@BloodAxe
Update configs names
d8f79da
@BloodAxe
Bugfix in post-processing callback for rescoring
e9eb3ba
@BloodAxe
Merge remote-tracking branch 'origin/feature/SG-707-rescoring-net' in…
351476a 
…to feature/SG-707-rescoring-net
@BloodAxe
Merge master
bea7154
@BloodAxe
Merge branch 'master' into feature/SG-707-rescoring-net
1affd39
@BloodAxe
Rename PoseEstimationDatasetIntegrationTest to PoseEstimationModelsIn…
ed1be3e 
…tegrationTest
@BloodAxe
Merge remote-tracking branch 'origin/feature/SG-707-rescoring-net' in…
122f113 
…to feature/SG-707-rescoring-net
@BloodAxe
Update models url's
9ae5060
@BloodAxe
Merge branch 'master' into feature/SG-707-rescoring-net
225811c
@BloodAxe
Merge branch 'master' into feature/SG-707-rescoring-net
8f1f42b
@BloodAxe
Merge branch 'master' into feature/SG-707-rescoring-net
405d66b
@BloodAxe
Merge branch 'master' into feature/SG-707-rescoring-net
47da0ee
@BloodAxe
Added direct link to test
3280bfb
@BloodAxe
Merge branch 'master' into feature/SG-707-rescoring-net
e8a7905
shaydeci
shaydeci approved these changes May 4, 2023
View reviewed changes
Copy link
Contributor

@shaydeci shaydeci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@BloodAxe BloodAxe merged commit ccbf015 into master May 4, 2023
@BloodAxe BloodAxe deleted the feature/SG-707-rescoring-net branch May 4, 2023 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shaydeci shaydeci shaydeci approved these changes

@ofrimasad ofrimasad Awaiting requested review from ofrimasad ofrimasad is a code owner

@Louis-Dupont Louis-Dupont Awaiting requested review from Louis-Dupont

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@BloodAxe @shaydeci