Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix train_loader not initalized properly #981

Merged
merged 4 commits into from
May 11, 2023
Merged

Fix train_loader not initalized properly #981

merged 4 commits into from
May 11, 2023

Conversation

Louis-Dupont
Copy link
Contributor

I am not sure why this error happens to begin (see #967), and I couldnt reproduce it, but this should fix it:

  • Make the code more robust to this type of error
  • Raise a more explicit error when user doesnt provide a loader and not loader found in cache.

@dagshub
Copy link

dagshub bot commented May 11, 2023

Join the discussion on DagsHub!

shaydeci
shaydeci approved these changes May 11, 2023
View reviewed changes
Copy link
Contributor

@shaydeci shaydeci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shaydeci shaydeci merged commit 9301db5 into master May 11, 2023
@shaydeci shaydeci deleted the SG-000/hotfix-fix_train_loader_error branch May 11, 2023 13:09
avideci pushed a commit that referenced this pull request May 23, 2023
@Louis-Dupont @avideci
Fix train_loader not initalized properly (#981)
7ec9535 
* fix

* fix typo

* typo
avideci pushed a commit that referenced this pull request May 23, 2023
@Louis-Dupont @avideci
Fix train_loader not initalized properly (#981)
5b7a589 
* fix

* fix typo

* typo
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shaydeci shaydeci shaydeci approved these changes

@ofrimasad ofrimasad Awaiting requested review from ofrimasad ofrimasad is a code owner

@BloodAxe BloodAxe Awaiting requested review from BloodAxe

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Louis-Dupont @shaydeci