Review eks documentation #137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 12 commits
May 2, 2023 17:30
PYLochou
approved these changes
May 5, 2023
mmouly
approved these changes
May 9, 2023
lgrateau
reviewed
May 9, 2023
platform/eks/README.md
Outdated
|
|
||
| ``` | ||
|
|
||
| Reference: https://docs.aws.amazon.com/eks/latest/userguide/create-cluster.html | ||
| > **Note** | ||
| > Use the latest kubernetes version available in AWS. Refer to [Amazon EKS Kubernetes versions](https://docs.aws.amazon.com/eks/latest/userguide/kubernetes-versions.html). |
There was a problem hiding this comment.
I prefer to put something like that.
The tutorial has been tested with the Kubernetes version 1.26. Check the supported kubernetes version in the system requirement page.
platform/eks/README-NGINX.md
Outdated
|
|
||
| - Get the [eks-rds-nginx-values.yaml](./eks-rds-nginx-values.yaml) file and replace the following keys: | ||
| - `<RDS_DB_ENDPOINT>`: your database server endpoint (of the form: `<INSTANCE_NAME>.xxxxxxxx.<REGION>.rds.amazonaws.com`) | ||
| - `<RDS_DATABASE_NAME>`: the initial database name defined when creating the RDS database | ||
|
|
||
| ```bash | ||
| helm install mycompany ibmcharts/ibm-odm-prod --version 22.2.0 -f eks-rds-nginx-values.yaml | ||
| helm install mycompany ibm-helm/ibm-odm-prod --version 22.2.0 -f eks-rds-nginx-values.yaml |
There was a problem hiding this comment.
The helm chart version should be updated to 23.1.0.
platform/eks/README.md
Outdated
| $ helm search repo ibm-odm-prod | ||
| NAME CHART VERSION APP VERSION DESCRIPTION | ||
| ibmcharts/ibm-odm-prod 22.2.0 8.11.1.0 IBM Operational Decision Manager | ||
| ibm-helm/ibm-odm-prod 22.2.0 8.11.1.0 IBM Operational Decision Manager |
There was a problem hiding this comment.
To be updated to 23.1.0 8.12.0.0
platform/eks/README.md
Outdated
| @@ -223,19 +228,21 @@ To install ODM with the AWS RDS PostgreSQL database created in [step 3](#3-creat | |||
| - `<RDS_DATABASE_NAME>` is the initial database name defined when creating the RDS database | |||
|
|
|||
| ```bash | |||
| helm install mycompany ibmcharts/ibm-odm-prod --version 22.2.0 -f eks-rds-values.yaml | |||
| helm install mycompany ibm-helm/ibm-odm-prod --version 22.2.0 -f eks-rds-values.yaml | |||
platform/eks/README.md
Outdated
| > | ||
| > - Get the [eks-values.yaml](./eks-values.yaml) file and replace the following key: | ||
| > - `<AWS-AccountId>` is your AWS Account Id | ||
| > | ||
| >```bash | ||
| >helm install mycompany ibmcharts/ibm-odm-prod --version 22.2.0 -f eks-values.yaml | ||
| >helm install mycompany ibm-helm/ibm-odm-prod --version 22.2.0 -f eks-values.yaml |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.