Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend command: "LifeSpan" #351

Merged
merged 4 commits into from
Nov 16, 2023

Conversation

MVladislav
Copy link
Contributor

Extend command: "LifeSpan"

See more general info and details under discussion.

  • Tested with Deebot T10 over HA - Deebot-4-Home-Assistant integration
  • Added unitCare as possible "LifeSpan" option
Ecovacs Home App Home Assistant
getLifeSpan getLifeSpan_home getLifeSpan_home2

Copy link

codecov bot commented Nov 15, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (b0c8565) 78.53% compared to head (50fd9bc) 78.54%.

Additional details and impacted files
@@           Coverage Diff           @@
##              dev     #351   +/-   ##
=======================================
  Coverage   78.53%   78.54%           
=======================================
  Files          59       59           
  Lines        2502     2503    +1     
  Branches      461      461           
=======================================
+ Hits         1965     1966    +1     
  Misses        494      494           
  Partials       43       43           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

MVladislav and others added 3 commits November 15, 2023 22:40
- add new "unitCare"
- add missing "sideBrush"
- reorder to have all at same place
@edenhaus edenhaus added the pr: new-feature PR, which adds a new feature label Nov 16, 2023
Copy link
Contributor

@edenhaus edenhaus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @MVladislav 👍

@edenhaus edenhaus merged commit 542e998 into DeebotUniverse:dev Nov 16, 2023
@MVladislav MVladislav deleted the feature/CommandLifeSpan branch November 16, 2023 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr: new-feature PR, which adds a new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants