-
-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add DEEBOT T10 TURBO #489
Add DEEBOT T10 TURBO #489
Conversation
According to ecovacs-deebot.js the base featureset for DEEBOT T10 TURBO Primarly copied from p95mgv.py upgraded with round mopping features
Warning Rate Limit Exceeded@Ulfmerbold2000 has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 37 minutes and 6 seconds before requesting another review. How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. WalkthroughThe Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
Review Details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- deebot_client/hardware/deebot/9s1s80.py (1 hunks)
Additional Context Used
Ruff (2)
deebot_client/hardware/deebot/9s1s80.py (2)
1-1: First line should end with a period
1-1: First line should end with a period, question mark, or exclamation point
Additional comments not posted (3)
deebot_client/hardware/deebot/9s1s80.py (3)
3-66
: The imports are well-organized and appropriate for the functionalities described.
104-226
: The device registration with its capabilities is correctly implemented and comprehensive.
106-226
: The configuration of capabilities is thorough and aligns well with the PR objectives, especially the addition of round mopping features.
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #489 +/- ##
==========================================
+ Coverage 85.45% 85.60% +0.15%
==========================================
Files 85 86 +1
Lines 3196 3231 +35
Branches 527 527
==========================================
+ Hits 2731 2766 +35
Misses 413 413
Partials 52 52 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @Ulfmerbold2000 👍
According to ecovacs-deebot.js the base featureset for DEEBOT T10 TURBO
Primarly copied from p95mgv.py upgraded with round mopping features in Lifespan
Summary by CodeRabbit