Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

the tria_io private subpackage had some unexpected error handling #50

Merged
merged 2 commits into from
Jan 9, 2024

Conversation

dkuegler
Copy link
Member

@dkuegler dkuegler commented Jan 8, 2024

  • if IO failed, the functions just returned None instead of raising an exception (which would be best practice) --> changed this to raising IOError exceptions, so proper error handling is possible
  • several messages meant for debugging were hard-coded, specifically the local verbose variables, best practice would be to handle this type of logging through the logging module

- if IO failed, the functions just returned None instead of raising an exception (which would be best practice) --> changed this to raising IOError exceptions, so proper error handling is possible
- several messages meant for debugging were hard-coded, specifically the local verbose variables, best practice would be to handle this type of logging through the logging module
Copy link

codecov bot commented Jan 8, 2024

Codecov Report

Attention: 39 lines in your changes are missing coverage. Please review.

Comparison is base (98b6d7b) 35.01% compared to head (dccd831) 34.92%.
Report is 6 commits behind head on main.

Files Patch % Lines
lapy/_tria_io.py 11.36% 39 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #50      +/-   ##
==========================================
- Coverage   35.01%   34.92%   -0.09%     
==========================================
  Files          14       14              
  Lines        2362     2365       +3     
  Branches      301      297       -4     
==========================================
- Hits          827      826       -1     
- Misses       1449     1455       +6     
+ Partials       86       84       -2     
Flag Coverage Δ
unittests 34.92% <11.36%> (-0.09%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@m-reuter m-reuter merged commit c0f5a7d into Deep-MI:main Jan 9, 2024
27 of 29 checks passed
@dkuegler dkuegler deleted the verbose+errors branch January 9, 2024 22:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants