Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fsinfo mesh information to some __init__ calls #62

Merged
merged 1 commit into from
Aug 9, 2024

Conversation

dkuegler
Copy link
Member

@dkuegler dkuegler commented Aug 9, 2024

TriaMesh internally calls __init__ in some cases to re-initialize member variables, if inplace operations changed the meshes.
However, when these are called the fsinfo attribute is missing from the call to __init__ resulting in the information in fsinfo getting lost.

I personally, do not really like to use __init__ as a method of the class outside of its use as a constructor. This is probably an example why this would be the case. It makes some differences less explicit and sometimes errors can appear. Maybe it should be considered to move this initialization functionality into an independent method.

@m-reuter m-reuter merged commit 20b7044 into Deep-MI:main Aug 9, 2024
16 of 27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants