Add fsinfo mesh information to some __init__ calls #62
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TriaMesh
internally calls__init__
in some cases to re-initialize member variables, if inplace operations changed the meshes.However, when these are called the fsinfo attribute is missing from the call to
__init__
resulting in the information in fsinfo getting lost.I personally, do not really like to use
__init__
as a method of the class outside of its use as a constructor. This is probably an example why this would be the case. It makes some differences less explicit and sometimes errors can appear. Maybe it should be considered to move this initialization functionality into an independent method.