Skip to content
This repository has been archived by the owner on Nov 28, 2023. It is now read-only.

Update DataSet.py #237

Closed
wants to merge 1 commit into from
Closed

Update DataSet.py #237

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions deeprank/learn/DataSet.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -283,9 +283,10 @@ def process_dataset(self):

# get the pairing
self.get_pairing_feature()

# get grid shape
self.get_grid_shape()

if self.grid_shape is None:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The if self.grid_shape is None condition has been considered in the function get_grid_shape, see the line 824 of the same file.

Copy link
Contributor Author

@manonreau manonreau Nov 10, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed but then the following elif condition is not correctly placed (line 839). It is more logical to remove the if self.grid_shape is None from that function and to enter the get_grid_shape function only if self.grid_shape does not exist.
This same issue is pointed out in #242

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I'll close this PR then.

# get grid shape
self.get_grid_shape()

# get the input shape
self.get_input_shape()
Expand Down