Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: cast hse feature to float64 #465

Merged
merged 1 commit into from
Aug 23, 2023
Merged

fix: cast hse feature to float64 #465

merged 1 commit into from
Aug 23, 2023

Conversation

DanLep97
Copy link
Collaborator

@DanLep97 DanLep97 commented Aug 7, 2023

PR for #463

@DanLep97 DanLep97 mentioned this pull request Aug 7, 2023
Closed
@DanLep97 DanLep97 self-assigned this Aug 7, 2023
@DanLep97 DanLep97 added the bug Something isn't working label Aug 7, 2023
@DanLep97 DanLep97 requested a review from gcroci2 August 7, 2023 15:28
@gcroci2 gcroci2 linked an issue Aug 8, 2023 that may be closed by this pull request
HDF5 file not generated when exposure feature module is used on PDB files from Propedia database #463
Closed
@gcroci2 gcroci2 changed the title fixed preprocessing fix: cast hse to float64 Aug 8, 2023
@gcroci2 gcroci2 changed the title fix: cast hse to float64 fix: cast hse feature to float64 Aug 8, 2023
@gcroci2 gcroci2 added the Query query module related issues label Aug 8, 2023
gcroci2
gcroci2 approved these changes Aug 8, 2023
View reviewed changes
Copy link
Collaborator

@gcroci2 gcroci2 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good that you noticed the error! Thanks for having fixed it :) You can merge and delete the branch

@github-actions
Copy link

This PR is stale because it has been open for 14 days with no activity.

@github-actions github-actions bot added the stale issue not touched from too much time label Aug 23, 2023
@gcroci2 gcroci2 merged commit 4091a9e into main Aug 23, 2023
@gcroci2 gcroci2 deleted the 463_fix_preprocess branch August 23, 2023 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gcroci2 gcroci2 gcroci2 approved these changes

Assignees

@DanLep97 DanLep97

Labels
bug Something isn't working Query query module related issues stale issue not touched from too much time
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

HDF5 file not generated when exposure feature module is used on PDB files from Propedia database
2 participants
@DanLep97 @gcroci2