Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: make scipy 1.11.2 work #482

Merged
merged 3 commits into from
Sep 4, 2023
Merged

fix: make scipy 1.11.2 work #482

merged 3 commits into from
Sep 4, 2023

Conversation

cbaakman
Copy link
Collaborator

@cbaakman cbaakman commented Sep 4, 2023

This error is described in #477. Converting the sparse array to a dense array type stops the error from appearing.

@cbaakman cbaakman requested a review from gcroci2 September 4, 2023 14:17
@cbaakman cbaakman self-assigned this Sep 4, 2023
@gcroci2 gcroci2 changed the title A fix for the scipy 1.11.2 related error. fix: make scipy 1.11.2 work Sep 4, 2023
@gcroci2 gcroci2 linked an issue Sep 4, 2023 that may be closed by this pull request
Investigate scipy 1.11.2 error #477
Closed
@gcroci2
Copy link
Collaborator

gcroci2 commented Sep 4, 2023

Let's wait for all the checks to pass, then we can merge

@github-actions
Copy link

github-actions bot commented Sep 4, 2023

Pull Request Test Coverage Report for Build 6075168663

  • 3 of 4 (75.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.1%) to 82.801%
Changes Missing Coverage Covered Lines Changed/Added Lines %
deeprank2/tools/visualization/plotting.py 1 2 50.0%
Totals Coverage Status
Change from base Build 6074522174: 0.1%
Covered Lines: 3311
Relevant Lines: 3925
💛 - Coveralls

@gcroci2 gcroci2 merged commit 3467412 into main Sep 4, 2023
@gcroci2 gcroci2 deleted the fix-scipy-1.11.2-error branch September 4, 2023 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gcroci2 gcroci2 gcroci2 approved these changes

Assignees

@cbaakman cbaakman

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Investigate scipy 1.11.2 error
2 participants
@cbaakman @gcroci2