Make general improvements and fix a couple of bugs #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: subham sarkar <subham@deepsource.io>
| @@ -40,12 +42,12 @@ func (tc *TemplateConfig) Validate() error { | |||
| return nil | |||
| } | |||
|
|
|||
| func (config *TemplateConfig) ReadYAML(configPath string) error { | |||
| func (tc *TemplateConfig) ReadYAML(configPath string) error { | |||
There was a problem hiding this comment.
Consistent with other receivers.
| @@ -3,18 +3,17 @@ module github.com/deepsourcelabs/hermes | |||
| go 1.17 | |||
There was a problem hiding this comment.
Updated modules
|
|
||
| for _, v := range store.cfg.Templates { | ||
| v := v |
There was a problem hiding this comment.
Although it is not currently not creating any issue (without the current fix) because of the nature of operations done inside the for statement but a slight change in the code could result in unpredictable behavior in case this fix is not applied.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes include:
github.com/sirupsen/logrusfor all i.e., removegithub.com/labstack/gommon/log(is it added by mistake?)go mod tidy -compat=1.17Signed-off-by: subham sarkar subham@deepsource.io