-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve the command cli interface #27
Open
signalpillar
wants to merge
9
commits into
Deepwalker:master
Choose a base branch
from
unknown repository
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem ------- The project avoids installing own dependencies so external library needs to be vendored or idea of having own small impl. should be improved. Current implementation shows the right direction but has lack of argument declaration/validation and thus documentation generation. Solution -------- Suggest an own argparser wrapper that leverages idea of using the subparsers and also allows using the decorators to mark the functions as commands. Other changes ------------- - Update CircleCI configuration to use v2 - https://circleci.com/blog/sunsetting-1-0/ - pundleapp is the new package. - removed some unused dependencies Testing ------- The existing tests pass.
It is WIP. I think this is the direction where you want to go and it is improving the existing state. What do you think? I am going to add the tests for the new module, so far. |
The tests are still running using CircleCi v1 that is disabled :( |
Testing ------- pyenv local system 3.6.5 tox
Example ``` usage: pundle run [-h] script [args [args ...]] Execute given script. Examples: | pundle run test.py -- 1 --help positional arguments: script args optional arguments: -h, --help show this help message and exit ```
This is how help looks like for one of the commands that have description in the command.
The
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The project avoids installing own dependencies so external library needs to be
vendored or idea of having own small impl. should be improved.
Current implementation shows the right direction but has lack of argument
declaration/validation and thus documentation generation.
Solution
Suggest an own argparser wrapper that leverages idea of using the subparsers and
also allows using the decorators to mark the functions as commands.
Other changes
https://circleci.com/blog/sunsetting-1-0/
Testing
The existing tests pass.