Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Defguard crashes after proxy stops #661

Closed
teon opened this issue Jul 4, 2024 · 2 comments
Closed

Defguard crashes after proxy stops #661

teon opened this issue Jul 4, 2024 · 2 comments
Assignees
Labels
bug Something isn't working

Comments

@teon
Copy link
Contributor

teon commented Jul 4, 2024

Reproduction:

#1

  1. Upgraded core from 0.10.0 to 0.11.0 without problems. Even core connected to the old 0.4.0 proxy.
  2. I've started the proxy upgrade process (docker down, pull, ...)
  3. During that time the proxy was not reachable
  4. Defguard core crashed, by going into infinite loop with logs:
defguard | 2024-07-04T15:37:47.643754Z  INFO defguard::grpc: Received message from proxy
defguard | 2024-07-04T15:37:47.643757Z ERROR defguard::grpc: stream error status: Internal, message: "Unexpected EOF decoding stream.", details: [], metadata: MetadataMap { headers: {} }
defguard | 2024-07-04T15:37:47.643760Z  INFO defguard::grpc: Received message from proxy
defguard | 2024-07-04T15:37:47.643763Z ERROR defguard::grpc: stream error status: Internal, message: "Unexpected EOF decoding stream.", details: [], metadata: MetadataMap { headers: {} }
defguard | 2024-07-04T15:37:47.643767Z  INFO defguard::grpc: Received message from proxy
defguard | 2024-07-04T15:37:47.643769Z ERROR defguard::grpc: stream error status: Internal, message: "Unexpected EOF decoding stream.", details: [], metadata: MetadataMap { headers: {} }
...
(100000 more lines :D )

2

  1. Upgraded the proxy & lanched new one
  2. Restarted core to connect to new proxy
  3. bliss . works. but:
  4. Stoped proxy
  5. Again core infinite looop and isn't reachable and logs the same as above.
@teon teon converted this from a draft issue Jul 4, 2024
@teon teon added the bug Something isn't working label Jul 4, 2024
@moubctez
Copy link
Contributor

moubctez commented Jul 5, 2024

The problem occurs when proxying the Proxy via Nginx.

Work around in #662

@moubctez moubctez assigned moubctez and unassigned t-aleksander Jul 5, 2024
t-aleksander added a commit that referenced this issue Jul 8, 2024
* Re-arrange proxy gRPC receiver loop; implement Display for MFAMethod

* Grammar fix

* Grammar fix in tests

---------

Co-authored-by: Aleksander <170264518+t-aleksander@users.noreply.github.com>
@t-aleksander t-aleksander moved this from Refined & Ready to Testing in Backlog & Roadmap Jul 8, 2024
@teon teon moved this from Testing to Done in Backlog & Roadmap Jul 8, 2024
@teon
Copy link
Contributor Author

teon commented Aug 15, 2024

Done in 0.11.0

@teon teon closed this as completed Aug 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done
Development

No branches or pull requests

3 participants