Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update protobuf to add alb_dns_name #49

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Update protobuf to add alb_dns_name #49

wants to merge 1 commit into from
+2,055 −519

Conversation

edwardrf
Copy link
Contributor

@edwardrf edwardrf commented Dec 6, 2024 •
edited by lionello
Loading

@edwardrf edwardrf requested a review from lionello December 6, 2024 19:54
@lionello lionello force-pushed the edw/aws-alb-dns-name branch from a1a571d to 14247b1 Compare February 7, 2025 22:55
lionello
lionello approved these changes Feb 7, 2025
View reviewed changes
Copy link
Member

@lionello lionello left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your PR title says alb_dns_name but you added lb_dns_name (without a)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lionello lionello lionello approved these changes

Assignees

@edwardrf edwardrf

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@edwardrf @lionello @edw-defang