Skip to content

Commit

Permalink
GHA workflows: don't persist git credentials (#5393)
Browse files Browse the repository at this point in the history
  • Loading branch information
valentijnscholten authored Nov 5, 2021
1 parent ee42232 commit 95c5c41
Show file tree
Hide file tree
Showing 8 changed files with 13 additions and 1 deletion.
1 change: 1 addition & 0 deletions .github/workflows/flake8.yml
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ jobs:
# more info https://github.saobby.my.eu.orgmunity/t/github-actions-are-severely-limited-on-prs/18179/16
# we checkout merge_commit here as this contains all new code from dev also. we don't need to compare against base_commit
with:
persist-credentials: false
fetch-depth: 0
ref: refs/pull/${{ github.event.pull_request.number }}/merge
# repository: ${{github.event.pull_request.head.repo.full_name}}
Expand Down
1 change: 1 addition & 0 deletions .github/workflows/gh-pages.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ jobs:
steps:
- uses: actions/checkout@v2
with:
persist-credentials: false
submodules: recursive # Fetch the Docsy theme
fetch-depth: 0 # Fetch all history for .GitInfo and .Lastmod

Expand Down
2 changes: 2 additions & 0 deletions .github/workflows/integration-tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,8 @@ jobs:

- name: Checkout
uses: actions/checkout@v2
with:
persist-credentials: false

- name: Read Docker Image Identifiers
id: read-docker-image-identifiers
Expand Down
2 changes: 2 additions & 0 deletions .github/workflows/k8s-testing.yml
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,8 @@ jobs:

- name: Checkout
uses: actions/checkout@v2
with:
persist-credentials: false

- name: Read Docker Image Identifiers
id: read-docker-image-identifiers
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/new-release-chart.yml
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ on:
inputs:
release_number:
description: 'Release number'
required: true
required: true

jobs:
release-chart:
Expand Down
3 changes: 3 additions & 0 deletions .github/workflows/plantuml.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,9 @@ jobs:
steps:
- name: Checkout Source
uses: actions/checkout@v2
with:
persist-credentials: false

- name: Get changed UML files
id: getfile
run: |
Expand Down
1 change: 1 addition & 0 deletions .github/workflows/test-helm-chart.yml
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ jobs:
- name: Checkout
uses: actions/checkout@v2
with:
persist-credentials: false
fetch-depth: 0

- name: Set up Helm
Expand Down
2 changes: 2 additions & 0 deletions .github/workflows/unit-tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,8 @@ jobs:

- name: Checkout
uses: actions/checkout@v2
with:
persist-credentials: false

# - name: Read Docker Image Identifiers
# id: read-docker-image-identifiers
Expand Down

0 comments on commit 95c5c41

Please sign in to comment.