Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MS Defender does not parse Endpoints right #11217

Closed
manuel-sommer opened this issue Nov 7, 2024 · 0 comments
Closed

MS Defender does not parse Endpoints right #11217

manuel-sommer opened this issue Nov 7, 2024 · 0 comments
Labels

Comments

@manuel-sommer
Copy link
Contributor

manuel-sommer commented Nov 7, 2024

Defender can be used (rolled out) on various devices: servers, mobile phones, IoT devices, clients. This results in broken endpoints, because DefectDojo parses "computerDNSName" as an endpoint. However, dropping this information is not beneficial as it is an important identifier especially for mobile phones, IoT devices and clients. The problem is that the computerDNSName of these devices do not always follow https://en.wikipedia.org/wiki/URL#Syntax.
Thus, this information needs to be cleaned up. An example is the following string:
Max Mustermann iPadAir 17zoll (2ndgeneration)

Maffooch pushed a commit that referenced this issue Nov 11, 2024
* 🐛 fix MSDefender computerDNSName to match modelregex

* 🐛 fix DefendercomputerDNSName is mostly a userinfo

* ruff

* fix according to review

* add unittest
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant