Fix for engagement_end_date not being used

[hblankenship]

When a scan was imported or reimported, the engagement_end_date was not being used and was defaulting to now + 365 days. This change sets the target_end appropriately for engagements.

[sc-8190]

[dryrunsecurity]

DryRun Security Summary

The code change in this pull request is a maintenance update that improves the handling of the engagement_end_date field in the CommonImportScanSerializer class of the Defect Dojo application's API, ensuring that the target_end field is only updated when the engagement_end_date is provided, preventing it from becoming None when the engagement_end_date is not present.

Expand for full summary

Summary:

The code change in this pull request appears to be a maintenance update that improves the handling of the engagement_end_date field in the CommonImportScanSerializer class of the Defect Dojo application's API. Previously, the target_end field was being set to the engagement_end_date regardless of whether the engagement_end_date was provided or not, which could lead to issues if the engagement_end_date was not provided. The change addresses this by only updating the target_end field if the engagement_end_date is actually provided, preventing the target_end field from becoming None when the engagement_end_date is not present.

From an application security perspective, this change does not introduce any obvious security concerns. It is a bug fix that enhances the reliability and consistency of the Defect Dojo application's API, without introducing any new functionality that could lead to security vulnerabilities. Overall, this code change is a positive maintenance update that improves the application's stability and user experience.

Files Changed:

• dojo/api_v2/serializers.py: The changes are made in the setup_common_context method of the CommonImportScanSerializer class. The update ensures that the target_end field is only updated when the engagement_end_date is provided, preventing it from becoming None when the engagement_end_date is not present.

Code Analysis

We ran 9 analyzers against 1 file and 0 analyzers had findings. 9 analyzers had no findings.

Riskiness

🟢 Risk threshold not exceeded.

View PR in the DryRun Dashboard.

[mtesauro]

Approved