Ruff: Add and fix PTH122

[manuel-sommer]

No description provided.

[dryrunsecurity]

DryRun Security Summary

The pull request covers changes to several files, including updates to the Ruff linter configuration, improvements to file handling and validation, and enhancements to the deduplication functionality, all aimed at improving the overall functionality and security of the DefectDojo application.

Expand for full summary

Summary:

The code changes in this pull request cover several files and focus on improving the overall functionality and security of the DefectDojo application. The changes include updates to the Ruff linter configuration, improvements to file handling and validation in the dojo/utils.py and dojo/forms.py files, and enhancements to the deduplication functionality in the dojo/models.py file.

While the specific changes do not directly address any known security vulnerabilities, they demonstrate the team's commitment to maintaining a secure and well-functioning application. The updates to the Ruff linter configuration, the use of the pathlib module for more robust file handling, and the improvements to the deduplication process all contribute to a more secure and maintainable codebase.

However, it's important to note that the overall security of the application should be regularly reviewed and assessed, as there may be other potential security risks that need to be addressed. This includes, but is not limited to, proper input validation and sanitization, secure file handling, access control and authorization, and the secure storage and transmission of sensitive data.

Files Changed:

1. ruff.toml: This file contains the configuration for the Ruff linter, a Python code linter. The changes include the addition of a new lint rule, "PTH122", and the removal of the "PTH124" lint rule. While these changes are not directly related to security vulnerabilities, the inclusion of security-related lint rules in the Ruff configuration suggests that the team is aware of common security pitfalls in Python development.

2. dojo/utils.py: The changes in this file involve the use of the pathlib.Path module to extract file extensions and generate file responses, instead of using the os.path module. These changes improve the reliability and robustness of the file handling functionality, but do not introduce any significant security concerns.

3. dojo/forms.py: The changes in this file focus on improving the file validation and extension checking when uploading files in the UploadThreatForm and the ManageFileFormSet. These changes help to prevent the upload of potentially malicious files, which is a positive step towards improving the overall security of the application.

4. dojo/models.py: The changes in this file are related to improving the deduplication functionality for findings in the DefectDojo application. The updates to the UniqueUploadNameProvider class and the compute_hash_code() method can help ensure that the deduplication process is more accurate and reliable, which can have a positive impact on the application's security and usability.

Code Analysis

We ran 9 analyzers against 4 files and 1 analyzer had findings. 8 analyzers had no findings.

Analyzer	Findings
Configured Codepaths Analyzer	5 findings

Riskiness

🔴 Risk threshold exceeded.

We've notified @mtesauro, @grendel513.

View PR in the DryRun Dashboard.

[cneill]

Just some quick cleanup, otherwise looks good

[mtesauro]

Approved