Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add cve values to openvas csv parser #9791

Merged
merged 4 commits into from
Mar 28, 2024
Merged

add cve values to openvas csv parser #9791

merged 4 commits into from
Mar 28, 2024

Conversation

manuel-sommer
Copy link
Contributor

See #9780

@dryrunsecurity DryRunSecurity
Copy link

dryrunsecurity bot commented Mar 20, 2024 •
edited
Loading

Hi there 👋, @DryRunSecurity here, below is a summary of our analysis and findings.

DryRun Security Status Findings
Sensitive Functions Analyzer ✅ 0 findings
Configured Sensitive Files Analyzer ✅ 0 findings
Sensitive Files Analyzer ❕ 1 findings

Note

🟢 Risk threshold not exceeded.

Tip

Get answers to your security questions. Add a comment in this PR starting with @DryRunSecurity. For example...

@dryrunsecurity What are common security issues with web application cookies?

Powered by DryRun Security

@manuel-sommer
Copy link
Contributor Author

@GilFernandes2000 fyi

mtesauro
mtesauro approved these changes Mar 22, 2024
View reviewed changes
Copy link
Contributor

@mtesauro mtesauro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

Maffooch
Maffooch requested changes Mar 25, 2024
View reviewed changes
Copy link
Contributor

@Maffooch Maffooch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The finding cve field will be deprecated in the near future. Please use the vulnerability_id field instead. It allows for having multiple CVEs on a single finding in the case of CveColumnMappingStrategy

@manuel-sommer manuel-sommer requested a review from Maffooch March 25, 2024 16:26
@manuel-sommer
Copy link
Contributor Author

Done, thank you for the review @Maffooch

Maffooch
Maffooch requested changes Mar 25, 2024
View reviewed changes
dojo/tools/openvas/csv_parser.py Outdated Show resolved Hide resolved
unittests/tools/test_openvas_parser.py Outdated Show resolved Hide resolved
This was referenced Mar 26, 2024
Merged
Merged
Merged
@manuel-sommer manuel-sommer requested a review from Maffooch March 27, 2024 11:23
This was referenced Mar 27, 2024
Merged
Merged
Merged
@mtesauro mtesauro merged commit 54cff2e into DefectDojo:dev Mar 28, 2024
121 checks passed
@manuel-sommer manuel-sommer deleted the add_cves_to_openvascsv_parser branch March 28, 2024 07:29
This was referenced Apr 8, 2024
Merged
Closed
This was referenced May 3, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blakeaowens blakeaowens blakeaowens approved these changes

@Maffooch Maffooch Maffooch approved these changes

@mtesauro mtesauro mtesauro approved these changes

@cneill cneill cneill approved these changes

Assignees
No one assigned
Labels
parser unittests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@manuel-sommer @cneill @mtesauro @Maffooch @blakeaowens