Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ruff: add and fix some of DJ rules #9891

Merged
merged 1 commit into from
Apr 30, 2024
Merged

Ruff: add and fix some of DJ rules #9891

merged 1 commit into from
Apr 30, 2024

Conversation

kiblik
Copy link
Contributor

@kiblik kiblik commented Apr 8, 2024

Fix some DJ rules - https://docs.astral.sh/ruff/rules/#flake8-django-dj

Included:

  • DJ003
  • DJ012
  • DJ013

Not included for now:

  • DJ001
  • DJ006
  • DJ007
  • DJ008

@dryrunsecurity DryRunSecurity
Copy link

dryrunsecurity bot commented Apr 8, 2024 •
edited
Loading

Hi there 👋, @DryRunSecurity here, below is a summary of our analysis and findings.

DryRun Security Status Findings
AppSec Analyzer (beta) ✅ 0 findings
Secrets Analyzer ✅ 0 findings
Authn/Authz Analyzer ❕ 4 findings
Configured Codepaths Analyzer ✅ 0 findings
Sensitive Files Analyzer ✅ 0 findings

Note

🟢 Risk threshold not exceeded.

Tip

Get answers to your security questions. Add a comment in this PR starting with @DryRunSecurity. For example...

@dryrunsecurity What are common security issues with web application cookies?

Powered by DryRun Security

@kiblik kiblik marked this pull request as ready for review April 8, 2024 15:50
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 9, 2024

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 9, 2024

Conflicts have been resolved. A maintainer will review the pull request shortly.

mtesauro
mtesauro approved these changes Apr 12, 2024
View reviewed changes
Copy link
Contributor

@mtesauro mtesauro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

Ruff issues are known and fixed in a different PR

@github-actions GitHub Actions
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions GitHub Actions
Copy link
Contributor

Conflicts have been resolved. A maintainer will review the pull request shortly.

@github-actions GitHub Actions
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions GitHub Actions
Copy link
Contributor

Conflicts have been resolved. A maintainer will review the pull request shortly.

@github-actions GitHub Actions
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions GitHub Actions
Copy link
Contributor

Conflicts have been resolved. A maintainer will review the pull request shortly.

@mtesauro
Copy link
Contributor

@kiblik We're close on this one - might fixing those merge conflicts so we can get this in?

@kiblik kiblik closed this Apr 30, 2024
@kiblik kiblik reopened this Apr 30, 2024
@Maffooch Maffooch merged commit e5c83b9 into DefectDojo:dev Apr 30, 2024
237 of 238 checks passed
@kiblik kiblik deleted the ruff_dj branch April 30, 2024 21:47
dogboat pushed a commit to dogboat/django-DefectDojo that referenced this pull request May 6, 2024
@kiblik
Ruff: add and fix some of DJ rules (DefectDojo#9891)
b007d28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Maffooch Maffooch Maffooch approved these changes

@hblankenship hblankenship hblankenship approved these changes

@mtesauro mtesauro mtesauro approved these changes

@cneill cneill cneill approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@kiblik @mtesauro @cneill @hblankenship @Maffooch