-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Newlines in SARIF parser code blocks #9932
Newlines in SARIF parser code blocks #9932
Conversation
Hi there 👋, @DryRunSecurity here, below is a summary of our analysis and findings.
Note 🟢 Risk threshold not exceeded. Powered by DryRun Security |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like the unit tests need to be updated as well
@Maffooch Whoops, I updated the unit tests. Could you approve rerunning the workflow? |
@ahmsec Tests have been re-kicked |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
@ahmsec This can be merged once the merge conflict is resolved. |
Conflicts have been resolved. A maintainer will review the pull request shortly. |
* code delimiters on separate lines * update unit tests
Description
Bug: The SARIF parser doesn't add a newline after the triple backticks for Markdown code blocks. This breaks code blocks on platforms like Jira, since that line is used for language identifiers. See for example https://docs.github.com/en/get-started/writing-on-github/working-with-advanced-formatting/creating-and-highlighting-code-blocks#syntax-highlighting.
Fix: This PR simply adds newlines to the Markdown code block delimiters.
Test results
./dc-unittest.sh --profile postgres-redis --test-case unittests.tools.test_sarif_parser.TestSarifParser
passesDocumentation
Checklist
This checklist is for your information.
dev
.dev
.bugfix
branch.