Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump GitHub version to version 2.4.1 #29

Merged
merged 2 commits into from
Nov 29, 2021
Merged

Bump GitHub version to version 2.4.1 #29

merged 2 commits into from
Nov 29, 2021

Conversation

noloader
Copy link
Contributor

Bump GitHub version to version 2.4.1

@mtesauro
Copy link
Collaborator

Thanks for this - I keep forgetting to rev the example 👍

@mtesauro mtesauro merged commit 42d215b into DefectDojo:master Nov 29, 2021
@noloader
Copy link
Contributor Author

@mtesauro,

No problems. While I've got your ear, two questions...

  1. Where is the mailing list or discussion board?
  2. Do you want a PR for README-PostgreSQL.md?

I needed to create a HowTo for our internal team. The HowTo will be the basis of README-PostgreSQL.md. It will be released under the same license DefectDojo uses.

@mtesauro
Copy link
Collaborator

(1) Most discussion happens on #defectdojo on the OWASP Slack instance. You can @ me there on Godojo questions.

(2) I assume README-PostgreSQL.md would be instructions for using Godojo with PostgreSQL, especially when it already exists and/or is separate from the Godojo installation. On my TODO for this week is to rename the ./scripts directory to ./docs-and-scripts and start putting documentation there so it's in the repo. I was also debating dropping things in GH wiki but I kinda prefer getting everything I need when I do a git clone rather then having to look at docs somewhere else. SO, if you want, drop it in ./scripts or ./docs-and-scripts if I beat you to your PR. I think that's a good place to gather related docs on using Godojo for now.

Cheers!

@noloader
Copy link
Contributor Author

noloader commented Nov 30, 2021

Thanks @mtesauro,

I started on a PR for Fedora support. It was intended to get beyond the "Unsupported OS to bootstrap, quitting" message. It is available at https://github.com/noloader/godojo/tree/fedora. Unfortunately, it is untested because I cannot get the installer to build on Fedora 35 or Ubuntu 20.04. I don't know the Go language so working though the problems is a bit much for me.

Would you like it as a PR?

@mtesauro
Copy link
Collaborator

mtesauro commented Dec 1, 2021

Don't know how I missed this update but, sure a PR is fine. If you do a PR, please do it against the dev branch. You can also just list out the OS commands that are needed to run on Fedora 35 and I can add those into godojo as well.

I'm currently working on extracting out to a separate package the addCmd, tryCmds, etc that I'm using to run OS commands so the code is less cluttered/cleaner so even just a list of Fedora commands is a great contribution.

I will also look at your fork to see if I can just pull out the Fedora specific stuff if a PR is hard to test on Fedora. Based on the issue you added, I'm guessing Fedora has an older version of Go that 1.16.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants