Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix type definition for package: apex.js #13825

Merged
3 commits merged into from
Jan 7, 2017
Merged

Conversation

y13i
Copy link
Contributor

@y13i y13i commented Jan 7, 2017

After #13796 has been merged, I noticed that it has an export default problem similar to this. It produces an error apex_js_1.default is not a function.

So I edited the definition and the test. Sorry for my poor checking before last PR.

Please fill in this template.

  • Make your PR against the master branch.
  • Use a meaningful title for the pull request. Include the name of the package modified.
  • Test the change in your own code. (Compile and run.)
  • Follow the advice from the readme.
  • Avoid common mistakes.
  • Run tsc without errors.
  • Run npm run lint package-name if a tslint.json is present.

Select one of these and delete the others:

If changing an existing definition:

  • Provide a URL to documentation or source code which provides context for the suggested changes: <>
  • Increase the version number in the header if appropriate.
  • If you are making substantial changes, consider adding a tslint.json containing { "extends": "../tslint.json" }.

@dt-bot
Copy link
Member

dt-bot commented Jan 7, 2017

apex.js/index.d.ts

to author (@y13i). Could you review this PR?
👍 or 👎?

Checklist

  • pass the Travis CI test?

@ghost ghost merged commit 1af69c4 into DefinitelyTyped:master Jan 7, 2017
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants