baidumap-web-sdk: Fix weak type errors #19196
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
types/baidumap-web-sdk/baidumap.overlay.d.ts to author (Codemonk (account can't be detected)). Could you review this PR? Checklist
|
Author
|
CC @wushilong |
typescript-bot
added
the
Unowned
Contributor
|
This PR has been open and unchanged 5 days without signoff or complaint. This will be merged by a maintainer soon if there are no objections. |
typescript-bot
added
the
Unmerged
ghost
merged commit
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was a compile error now thanks to microsoft/TypeScript#16047.
When a class implements an interface it normally has to redeclare all of the interface's members. (We weren't catching that because all of the members of
Overlaywere optional, so a class could declare itself to implementOverlaywithout actually implementing anything.)We can fix this problem by merging the class with an interface extending
Overlay, so it gets all of the members ofOverlaywithout having to redeclare them.