Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert yet more import * to import = #23464

Merged
merged 1 commit into from
Feb 14, 2018
Merged

Convert yet more import * to import = #23464

merged 1 commit into from
Feb 14, 2018

Conversation

ghost
Copy link

@ghost ghost commented Feb 6, 2018

Sequel to #23461

@ghost ghost force-pushed the import_equals_more branch from 5675ff8 to e54d6d1 Compare February 6, 2018 18:31
@typescript-bot
Copy link
Contributor

typescript-bot commented Feb 6, 2018 •
edited
Loading

@andy-ms Thank you for submitting this PR!

🔔 @spacejack @andraaspar @isiahmeadows @djpereira @wonbyte @swist @alitaheri @Burgov @wilgert @franjuan @MartynasZilinskas @jacobbaskin @mgroenhoff @shiftkey @j-f1 @stephenlautier @CzBuCHi @cvle @nenadalm @vforv @pawsong @taoqf @Archcry @IceOnFire @bradzacher @janhommes @jcchalte @chbrown @3fd @westy92 @CatGuardian @sgmccli @Zelein @hellochar @rsxdalv @SamVerschueren @mad-mike @MidnightDesign @wake42 @Sayan751 @charrondev @AGBrown @geppy @fredgalvao @spaulg @trubit @TobiasBales @geoffreak @DenisCarriere @MugeSo @bitbankinc @rollymaduk @seansfkelley @tlaziuk @chiubaka @uncovertruth @LKay @tkrotoff @unional @ianks @bobbuehler @secondwtq @rogierschouten @afshin @BehindTheMath @SeanSobey @ssttevee @zivni @alex3165 @xsburg @geirsagberg @renjfk @psnider @lith-light-g @toddself @bastienmoulia @cxcorp @will-ockmore @cyrilschumacher @TonyPythoneer @khoomeister @dmoonfire @timbru31 @dolanmiu @SuperPaintman @evanshortiss @j3ko @dex4er @GiedriusGrabauskas @idchlife @plantain-00 @devrelm @mrkmg @SamVerschueren @danmana @oddeirik @vbortone @scleriot @SWBennett06 @IgelCampus @bsurai @KSDaemon @Codesleuth @aicest @daprahamian - please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

If no reviewer appears after a week, a DefinitelyTyped maintainer will review the PR instead.

@typescript-bot typescript-bot added Popular package This PR affects a popular package (as counted by NPM download counts). Awaiting reviewer feedback labels Feb 6, 2018
@geppy
Copy link
Contributor

geppy commented Feb 6, 2018

reasoning behind the changes (re: Microsoft/TypeScript#21535)

geppy
geppy approved these changes Feb 6, 2018
View reviewed changes
Copy link
Contributor

@geppy geppy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving the PouchDB changes, at least.

sgmccli
sgmccli approved these changes Feb 6, 2018
View reviewed changes
Copy link
Contributor

@sgmccli sgmccli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving parent-package-json

@typescript-bot
Copy link
Contributor

A definition author has approved this PR ⭐️. A maintainer will merge this PR shortly. If it shouldn't be merged yet, please leave a comment saying so and we'll wait. Thank you for your contribution to DefinitelyTyped!

dead-claudia
dead-claudia reviewed Feb 7, 2018
View reviewed changes
types/mithril/test/test-api.ts
import * as m from 'mithril';
import * as stream from 'mithril/stream';
import m = require('mithril');
import stream = require('mithril/stream');
Copy link
Contributor

@dead-claudia dead-claudia Feb 7, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@spacejack We really should convert Mithril's value-level exports to just be default exports, so we remain ES6-compatible. Yes, it's breaking, but we're going to have to do it regardless. Just a note for later.

@DanielRosenwasser DanielRosenwasser merged commit 44b0c07 into master Feb 14, 2018
@elibarzilay elibarzilay deleted the import_equals_more branch November 28, 2020 23:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Popular package This PR affects a popular package (as counted by NPM download counts).
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.