-
Notifications
You must be signed in to change notification settings - Fork 30.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(GraphQL): add additional GraphQL ParseOptions #23525
Conversation
@colepatrickturner Thank you for submitting this PR! 🔔 @TonyPythoneer @calebmer @intellix @firede @kepennar @freiksenet @IvanGoncharov @DxCx @rportugal - please review this PR in the next few days. Be sure to explicitly select If no reviewer appears after a week, a DefinitelyTyped maintainer will review the PR instead. |
types/graphql/language/parser.d.ts
Outdated
noLocation?: boolean, | ||
allowLegacySDLEmptyFields?: boolean, | ||
allowLegacySDLImplementsInterfaces?: boolean, | ||
experimentalFragmentVariables?: boolean, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@colepatrickturner Can you please also copy options descriptions:
https://github.com/graphql/graphql-js/blob/98751e473fd7a02c514af48218d87d26daadb5f5/src/language/parser.js#L79-L115
92deb7c
to
a3654ee
Compare
@IvanGoncharov I have added the comment descriptions, thanks! |
A definition author has approved this PR ⭐️. A maintainer will merge this PR shortly. If it shouldn't be merged yet, please leave a comment saying so and we'll wait. Thank you for your contribution to DefinitelyTyped! |
Thanks! |
Please fill in this template.
npm run lint package-name
(ortsc
if notslint.json
is present).Select one of these and delete the others:
If changing an existing definition:
If you are making substantial changes, consider adding atslint.json
containing{ "extends": "dtslint/dt.json" }
.