Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[plotly.js] added typed array to scatter data #25608

Merged
merged 1 commit into from
May 8, 2018
Merged

[plotly.js] added typed array to scatter data #25608

merged 1 commit into from
May 8, 2018

Conversation

veggiesaurus
Copy link
Contributor

@veggiesaurus veggiesaurus commented May 8, 2018

Typed arrays were added as a possible scatter data type in version 1.35. This PR updates the type definition to allow the x, y, or z fields of the ScatterData interface to be populated by a typed array.

Please fill in this template.

  • Use a meaningful title for the pull request. Include the name of the package modified.
  • Test the change in your own code. (Compile and run.)
  • Add or edit tests to reflect the change. (Run with npm test.)
  • Follow the advice from the readme.
  • Avoid common mistakes.
  • Run npm run lint package-name (or tsc if no tslint.json is present).

Select one of these and delete the others:

If changing an existing definition:

@typescript-bot
Copy link
Contributor

typescript-bot commented May 8, 2018

@veggiesaurus Thank you for submitting this PR!

🔔 @chrisgervang @martinduparc @frederikaalund @taoqf @Dadstart @szechyjs - please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

If no reviewer appears after a week, a DefinitelyTyped maintainer will review the PR instead.

@typescript-bot typescript-bot added Owner Approved A listed owner of this package signed off on the pull request. Merge:Express and removed Awaiting reviewer feedback labels May 8, 2018
@typescript-bot
Copy link
Contributor

A definition owner has approved this PR ⭐️. A maintainer will merge this PR shortly. If it shouldn't be merged yet, please leave a comment saying so and we'll wait. Thank you for your contribution to DefinitelyTyped!

@sheetalkamat sheetalkamat merged commit fdd6013 into DefinitelyTyped:master May 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Owner Approved A listed owner of this package signed off on the pull request.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants