Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[node] Improve http2 definitions #33019

Closed
wants to merge 4 commits into from
Closed

[node] Improve http2 definitions #33019

wants to merge 4 commits into from

Conversation

alessiodionisi
Copy link
Contributor

Changes:

  • Http2ServerResponse extends stream.Writable instead of events.EventEmitter

Checks:

@typescript-bot typescript-bot added Popular package This PR affects a popular package (as counted by NPM download counts). The Travis CI build failed labels Feb 13, 2019
@typescript-bot
Copy link
Contributor

typescript-bot commented Feb 13, 2019

@adnsio Thank you for submitting this PR!

🔔 @microsoft @DefinitelyTyped @jkomyno @a-tarasyuk @alvis @r3nya @btoueg @BrunoScheufler @smac89 @tellnes @Touffy @DeividasBakanas @eyqs @Flarna @Hannes-Magnusson-CK @KSXGitHub @hoo29 @kjin @ajafff @islishude @mwiktorczyk @matthieusieben @mohsen1 @n-e @octo-sniffle @parambirs @eps1lon @SimonSchick @ThomasdenH @WilcoBakker @wwwy3y3 @ZaneHannanAU @jeremiergz @samuela @kuehlein @j-oliveras @bhongy - please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

If no reviewer appears after a week, a DefinitelyTyped maintainer will review the PR instead.

@typescript-bot
Copy link
Contributor

typescript-bot commented Feb 13, 2019

@adnsio The Travis CI build failed! Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

@chyzwar
Copy link
Contributor

chyzwar commented Feb 13, 2019

Http2ServerResponse and Http2ServerRequest have their constructor marked a private. But according to the documentation, it should be possible to extend them.

https://nodejs.org/api/http2.html#http2_http2_createsecureserver_options_onrequesthandler
nodejs/node#15560

As a part of this PR can you into changing access modifier for these constructors?

@typescript-bot
Copy link
Contributor

typescript-bot commented Feb 13, 2019

@adnsio The Travis CI build failed! Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

Copy link
Contributor

@SimonSchick SimonSchick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests pls, (only needed for v11).
Feel also free to move the http2 section from node-tests.ts to /test/http2.ts, that's entirely optional tho.

@typescript-bot typescript-bot added the Revision needed This PR needs code changes before it can be merged. label Feb 13, 2019
- Moved tests to folder
- Added tests for aborted and authority on request
- Added tests for flushHeaders on response
- Removed http2 tests from node-tests.ts
@typescript-bot
Copy link
Contributor

typescript-bot commented Feb 14, 2019

@adnsio The Travis CI build failed! Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

@alessiodionisi
Copy link
Contributor Author

@SimonSchick I've added some tests and moved all to test/http2.ts.

@typescript-bot typescript-bot added the Owner Approved A listed owner of this package signed off on the pull request. label Feb 14, 2019
@typescript-bot
Copy link
Contributor

@adnsio I haven't seen anything from you in a while and this PR currently has problems that prevent it from being merged. The PR will be closed tomorrow if there aren't new commits to fix the issues.

@typescript-bot typescript-bot added the Abandoned This PR had no activity for a long time, and is considered abandoned label Feb 21, 2019
@typescript-bot
Copy link
Contributor

@adnsio To keep things tidy, we have to close PRs that aren't mergeable but don't have activity from their author. No worries, though - please open a new PR if you'd like to continue with this change. Thank you!

@alessiodionisi
Copy link
Contributor Author

@SimonSchick @Flarna someone can merge this pull request?

@Flarna
Copy link
Contributor

Flarna commented Feb 22, 2019

@sanders could you please re-open and merge this? CI fails are unrelated as far as I can see.

@amcasey amcasey reopened this Feb 22, 2019
@typescript-bot typescript-bot added Merge:Express and removed The Travis CI build failed Abandoned This PR had no activity for a long time, and is considered abandoned labels Feb 22, 2019
@typescript-bot
Copy link
Contributor

A definition owner has approved this PR ⭐️. A maintainer will merge this PR shortly. If it shouldn't be merged yet, please leave a comment saying so and we'll wait. Thank you for your contribution to DefinitelyTyped!

@amcasey
Copy link
Contributor

amcasey commented Feb 22, 2019

We're having CI problems that are causing significant issues for widely consumed packages (esp Node). We know how frustrating it is and we're working on a fix, which you can track here: microsoft/TypeScript#29898. Sorry!

@typescript-bot typescript-bot added The Travis CI build failed Abandoned This PR had no activity for a long time, and is considered abandoned and removed Merge:Express labels Feb 22, 2019
@Flarna Flarna mentioned this pull request Feb 26, 2019
9 tasks
@sandersn sandersn reopened this Feb 28, 2019
@typescript-bot typescript-bot added Merge:Express and removed The Travis CI build failed Abandoned This PR had no activity for a long time, and is considered abandoned labels Feb 28, 2019
@typescript-bot typescript-bot added Has Merge Conflict This PR can't be merged because it has a merge conflict. The author needs to update it. and removed Merge:Express labels Mar 1, 2019
@typescript-bot
Copy link
Contributor

@adnsio Unfortunately, this pull request currently has a merge conflict 😥. Please update your PR branch to be up-to-date with respect to master. Have a nice day!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Has Merge Conflict This PR can't be merged because it has a merge conflict. The author needs to update it. Owner Approved A listed owner of this package signed off on the pull request. Popular package This PR affects a popular package (as counted by NPM download counts). Revision needed This PR needs code changes before it can be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants