Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed MDPalette definition. #4479

Merged
merged 2 commits into from Jun 7, 2015
Merged

Fixed MDPalette definition. #4479

merged 2 commits into from Jun 7, 2015

Conversation

ghost
Copy link

@ghost ghost commented May 28, 2015

The values should be a string array and contrastStrongLightColors should be contrastLightColors

@vvakame
Copy link
Member

vvakame commented May 31, 2015

angular-material/angular-material.d.ts

to author(@mtraynham). could you review this PR?
👍 or 👎?

check list

  • pass the Travic-CI test?

@mtraynham
Copy link
Contributor

@robertbaker
The property name change looks correct, but the type should be a union of string|string[].

Palettes use simple strings here:
https://github.com/angular/material/blob/master/src/core/services/theming/theme.palette.js#L20

But the code accepts an array or if string splits and converts it to an array:
https://github.com/angular/material/blob/master/src/core/services/theming/theming.js#L535

Ultimately, these properties get deleted from the palette, so they are only used at creation of the palette and not present in retrieval:
https://github.com/angular/material/blob/master/src/core/services/theming/theming.js#L538

@ghost
Copy link
Author

ghost commented Jun 1, 2015

Changed it.

@mtraynham
Copy link
Contributor

LGTM thanks @robertbaker

vvakame added a commit that referenced this pull request Jun 7, 2015
@vvakame
Merge pull request #4479 from robertbaker/patch-1
d7e649f 
Fixed MDPalette definition.
@vvakame vvakame merged commit d7e649f into DefinitelyTyped:master Jun 7, 2015
@vvakame
Copy link
Member

vvakame commented Jun 7, 2015

@mtraynham thanks!
@robertbaker thanks mate!

lora-reames added a commit to lora-reames/DefinitelyTyped that referenced this pull request Aug 28, 2017
@lora-reames
mapbox-gl: GeolocateControl support v0.39.0
96781a6 
https://github.com/mapbox/mapbox-gl-js/releases/tag/v0.39.0
⚠️ Breaking changes

GeolocateControl breaking changes [DefinitelyTyped#4479](mapbox/mapbox-gl-js#4479)
The option watchPosition has been replaced with trackUserLocation
The camera operation has changed from jumpTo (not animated) to fitBounds (animated). An effect of this is the map pitch is no longer reset, although the bearing is still reset to 0.
The accuracy of the geolocation provided by the device is used to set the view (previously it was fixed at zoom level 17). The maxZoom can be controlled via the new fitBoundsOptions option (defaults to 15).
This was referenced Jul 13, 2021
Open
Open
Open
Open
This was referenced Jul 21, 2021
Open
Closed
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vvakame @mtraynham