Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[plotly.js] Update to include sunburst specific properties and sunburstclick event #48963

Merged

Conversation

MikeRippon
Copy link
Contributor

The documentation on sunburst point data seems to be non-existent, and it seems to have very different properties to the existing PlotDatum definition (the docs say that it depends on trace type) so I made a new SunburstPlotDatum definition with all the properties I could sensibly figure out! Descriptions are in the test. Hope this is suitable!

  • Use a meaningful title for the pull request. Include the name of the package modified.
  • Test the change in your own code. (Compile and run.)
  • Add or edit tests to reflect the change. (Run with npm test YOUR_PACKAGE_NAME.)
  • Follow the advice from the readme.
  • Avoid common mistakes.
  • Run npm run lint package-name (or tsc if no tslint.json is present).

Select one of these and delete the others:

If changing an existing definition:

@typescript-bot
Copy link
Contributor

typescript-bot commented Oct 20, 2020

@LittleMikeDev Thank you for submitting this PR! I see this is your first time submitting to DefinitelyTyped 👋 — I'm the local bot who will help you through the process of getting things through.

This is a live comment which I will keep updated.

1 package in this PR

Code Reviews

Because you edited one package and updated the tests (👏), I can help you merge this PR once someone else signs off on it.

Status

  • ✅ No merge conflicts
  • ✅ Continuous integration tests have passed
  • ✅ Most recent commit is approved by type definition owners or DT maintainers

All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes.


Diagnostic Information: What the bot saw about this PR
{
  "type": "info",
  "now": "-",
  "pr_number": 48963,
  "author": "LittleMikeDev",
  "owners": [
    "chrisgervang",
    "martinduparc",
    "frederikaalund",
    "taoqf",
    "Dadstart",
    "szechyjs",
    "MercifulCode",
    "soorajpudiyadath",
    "jonfreedman",
    "meganrm",
    "milesjos",
    "skippercool",
    "zeroyoichihachi",
    "mtadams007",
    "marnett-git",
    "peterblazejewicz",
    "brammitch",
    "blizzardjessica",
    "olegshilov"
  ],
  "dangerLevel": "ScopedAndTested",
  "headCommitAbbrOid": "abb3d7a",
  "headCommitOid": "abb3d7a335d14bd2efb4d900708f405ddc3cb42c",
  "mergeIsRequested": true,
  "stalenessInDays": 0,
  "lastPushDate": "2020-10-20T19:06:12.000Z",
  "lastCommentDate": "2020-10-28T17:49:04.000Z",
  "maintainerBlessed": false,
  "reviewLink": "https://github.com/DefinitelyTyped/DefinitelyTyped/pull/48963/files",
  "hasMergeConflict": false,
  "authorIsOwner": false,
  "isFirstContribution": true,
  "popularityLevel": "Popular",
  "newPackages": [],
  "packages": [
    "plotly.js"
  ],
  "files": [
    {
      "path": "types/plotly.js/index.d.ts",
      "kind": "definition",
      "package": "plotly.js"
    },
    {
      "path": "types/plotly.js/test/index-tests.ts",
      "kind": "test",
      "package": "plotly.js"
    }
  ],
  "hasDismissedReview": false,
  "ciResult": "pass",
  "lastReviewDate": "2020-10-28T17:48:11.000Z",
  "firstApprovalDate": "2020-10-28T17:48:11.000Z",
  "reviewersWithStaleReviews": [],
  "approvalFlags": 2,
  "isChangesRequested": false
}

@typescript-bot
Copy link
Contributor

🔔 @chrisgervang @martinduparc @frederikaalund @taoqf @Dadstart @szechyjs @MercifulCode @soorajpudiyadath @jonfreedman @meganrm @milesjos @SkipperCool @zeroyoichihachi @mtadams007 @marnett-git @peterblazejewicz @brammitch @blizzardjessica @olegshilov — please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

@typescript-bot typescript-bot added Popular package This PR affects a popular package (as counted by NPM download counts). and removed Popular package This PR affects a popular package (as counted by NPM download counts). labels Oct 21, 2020
@typescript-bot typescript-bot added the Popular package This PR affects a popular package (as counted by NPM download counts). label Oct 28, 2020
Copy link
Contributor

@brammitch brammitch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@typescript-bot typescript-bot added Owner Approved A listed owner of this package signed off on the pull request. Self Merge This PR can now be self-merged by the PR author or an owner labels Oct 28, 2020
@typescript-bot
Copy link
Contributor

@LittleMikeDev Everything looks good here. Great job! I am ready to merge this PR on your behalf.

If you'd like that to happen, please post a comment saying:

Ready to merge

and I'll merge this PR almost instantly. Thanks for helping out! ❤️

(@chrisgervang, @martinduparc, @frederikaalund, @taoqf, @Dadstart, @szechyjs, @MercifulCode, @soorajpudiyadath, @jonfreedman, @meganrm, @milesjos, @SkipperCool, @zeroyoichihachi, @mtadams007, @marnett-git, @peterblazejewicz, @brammitch, @blizzardjessica, @olegshilov: you can do this too.)

@brammitch
Copy link
Contributor

Ready to merge

@typescript-bot typescript-bot merged commit 8d6fe5d into DefinitelyTyped:master Oct 28, 2020
@typescript-bot
Copy link
Contributor

I just published @types/plotly.js@1.54.2 to npm.

@MikeRippon MikeRippon deleted the plotly-js-sunburst-click branch November 9, 2020 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Owner Approved A listed owner of this package signed off on the pull request. Popular package This PR affects a popular package (as counted by NPM download counts). Self Merge This PR can now be self-merged by the PR author or an owner
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants