chore: remove ts3.6 support #54895
Merged
chore: remove ts3.6 support #54895
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SimonSchick
requested review from
Igorbek,
Jessidhia and
peterblazejewicz
as code owners
|
@SimonSchick Thank you for submitting this PR! This is a live comment which I will keep updated. 8 packages in this PR
Code ReviewsBecause this is a widely-used package, a DT maintainer will need to review it before it can be merged. You can test the changes of this PR in the Playground. Status
All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes. Diagnostic Information: What the bot saw about this PR{
"type": "info",
"now": "-",
"pr_number": 54895,
"author": "SimonSchick",
"headCommitOid": "328163c8c200554c1d00e1aa48165ff0f7fff17a",
"lastPushDate": "2021-08-24T14:42:44.000Z",
"lastActivityDate": "2021-08-26T00:47:23.000Z",
"mergeOfferDate": "2021-08-25T23:26:03.000Z",
"mergeRequestDate": "2021-08-26T00:47:23.000Z",
"mergeRequestUser": "SimonSchick",
"hasMergeConflict": false,
"isFirstContribution": false,
"tooManyFiles": false,
"popularityLevel": "Critical",
"pkgInfo": [
{
"name": "assert",
"kind": "edit",
"files": [
{
"path": "types/assert/package.json",
"kind": "package-meta-ok"
},
{
"path": "types/assert/ts3.6/assert-tests.ts",
"kind": "test"
},
{
"path": "types/assert/ts3.6/index.d.ts",
"kind": "definition"
},
{
"path": "types/assert/ts3.6/tsconfig.json",
"kind": "package-meta-ok"
},
{
"path": "types/assert/ts3.6/tslint.json",
"kind": "package-meta-ok"
}
],
"owners": [
"nicoabie",
"LinusU",
"ExE-Boss"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Popular"
},
{
"name": "babel-types",
"kind": "edit",
"files": [
{
"path": "types/babel-types/babel-types-tests.ts",
"kind": "test"
},
{
"path": "types/babel-types/index.d.ts",
"kind": "definition"
},
{
"path": "types/babel-types/package.json",
"kind": "package-meta-ok"
},
{
"path": "types/babel-types/ts3.6/babel-types-tests.ts",
"kind": "test"
},
{
"path": "types/babel-types/ts3.6/index.d.ts",
"kind": "definition"
},
{
"path": "types/babel-types/ts3.6/tsconfig.json",
"kind": "package-meta-ok"
},
{
"path": "types/babel-types/ts3.6/tslint.json",
"kind": "package-meta-ok"
}
],
"owners": [
"yortus",
"baxtersa",
"marvinhagemeister",
"bcherny",
"ExE-Boss"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Popular"
},
{
"name": "codecs",
"kind": "edit",
"files": [
{
"path": "types/codecs/package.json",
"kind": "package-meta-ok"
},
{
"path": "types/codecs/ts3.6/codecs-tests.ts",
"kind": "test"
},
{
"path": "types/codecs/ts3.6/index.d.ts",
"kind": "definition"
},
{
"path": "types/codecs/ts3.6/tsconfig.json",
"kind": "package-meta-ok"
},
{
"path": "types/codecs/ts3.6/tslint.json",
"kind": "package-meta-ok"
}
],
"owners": [
"martinheidegger"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Well-liked by everyone"
},
{
"name": "http-assert",
"kind": "edit",
"files": [
{
"path": "types/http-assert/package.json",
"kind": "package-meta-ok"
},
{
"path": "types/http-assert/ts3.6/http-assert-tests.ts",
"kind": "test"
},
{
"path": "types/http-assert/ts3.6/index.d.ts",
"kind": "definition"
},
{
"path": "types/http-assert/ts3.6/tsconfig.json",
"kind": "package-meta-ok"
},
{
"path": "types/http-assert/ts3.6/tslint.json",
"kind": "package-meta-ok"
}
],
"owners": [
"jkeylu",
"stripedpajamas",
"sapfear"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Critical"
},
{
"name": "invariant",
"kind": "edit",
"files": [
{
"path": "types/invariant/package.json",
"kind": "package-meta-ok"
},
{
"path": "types/invariant/ts3.6/index.d.ts",
"kind": "definition"
},
{
"path": "types/invariant/ts3.6/invariant-tests.ts",
"kind": "test"
},
{
"path": "types/invariant/ts3.6/tsconfig.json",
"kind": "package-meta-ok"
},
{
"path": "types/invariant/ts3.6/tslint.json",
"kind": "package-meta-ok"
}
],
"owners": [
"bennett000",
"dtinth",
"turadg"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Popular"
},
{
"name": "node",
"kind": "edit",
"files": [
{
"path": "types/node/base.d.ts",
"kind": "definition"
},
{
"path": "types/node/index.d.ts",
"kind": "definition"
},
{
"path": "types/node/node-tests.ts",
"kind": "test"
},
{
"path": "types/node/package.json",
"kind": "package-meta-ok"
},
{
"path": "types/node/scripts/generate-docs/docs.ts",
"kind": "test"
},
{
"path": "types/node/test/assert.ts",
"kind": "test"
},
{
"path": "types/node/ts3.6/assert.d.ts",
"kind": "definition"
},
{
"path": "types/node/ts3.6/base.d.ts",
"kind": "definition"
},
{
"path": "types/node/ts3.6/index.d.ts",
"kind": "definition"
},
{
"path": "types/node/ts3.6/node-tests.ts",
"kind": "test"
},
{
"path": "types/node/ts3.6/tsconfig.json",
"kind": "package-meta-ok"
},
{
"path": "types/node/ts3.6/tslint.json",
"kind": "package-meta-ok"
},
{
"path": "types/node/v12/base.d.ts",
"kind": "definition"
},
{
"path": "types/node/v12/index.d.ts",
"kind": "definition"
},
{
"path": "types/node/v12/node-tests.ts",
"kind": "test"
},
{
"path": "types/node/v12/package.json",
"kind": "package-meta-ok"
},
{
"path": "types/node/v12/test/assert.ts",
"kind": "test"
},
{
"path": "types/node/v12/ts3.6/assert.d.ts",
"kind": "definition"
},
{
"path": "types/node/v12/ts3.6/base.d.ts",
"kind": "definition"
},
{
"path": "types/node/v12/ts3.6/index.d.ts",
"kind": "definition"
},
{
"path": "types/node/v12/ts3.6/node-tests.ts",
"kind": "test"
},
{
"path": "types/node/v12/ts3.6/tsconfig.json",
"kind": "package-meta-ok"
},
{
"path": "types/node/v12/ts3.6/tslint.json",
"kind": "package-meta-ok"
},
{
"path": "types/node/v12/tsconfig.json",
"kind": "package-meta",
"suspect": "not [the expected form](https://github.com/DefinitelyTyped/DefinitelyTyped#user-content-tsconfigjson) and not moving towards it (check: `compilerOptions.lib.0`, `compilerOptions.target`)"
},
{
"path": "types/node/v14/base.d.ts",
"kind": "definition"
},
{
"path": "types/node/v14/index.d.ts",
"kind": "definition"
},
{
"path": "types/node/v14/node-tests.ts",
"kind": "test"
},
{
"path": "types/node/v14/package.json",
"kind": "package-meta-ok"
},
{
"path": "types/node/v14/test/assert.ts",
"kind": "test"
},
{
"path": "types/node/v14/ts3.6/assert.d.ts",
"kind": "definition"
},
{
"path": "types/node/v14/ts3.6/base.d.ts",
"kind": "definition"
},
{
"path": "types/node/v14/ts3.6/index.d.ts",
"kind": "definition"
},
{
"path": "types/node/v14/ts3.6/node-tests.ts",
"kind": "test"
},
{
"path": "types/node/v14/ts3.6/tsconfig.json",
"kind": "package-meta-ok"
},
{
"path": "types/node/v14/ts3.6/tslint.json",
"kind": "package-meta-ok"
},
{
"path": "types/node/v14/tsconfig.json",
"kind": "package-meta",
"suspect": "not [the expected form](https://github.com/DefinitelyTyped/DefinitelyTyped#user-content-tsconfigjson) and not moving towards it (check: `compilerOptions.lib.0`, `compilerOptions.target`)"
}
],
"owners": [
"Microsoft",
"DefinitelyTyped",
"jkomyno",
"alvis",
"r3nya",
"btoueg",
"smac89",
"touffy",
"DeividasBakanas",
"eyqs",
"Hannes-Magnusson-CK",
"KSXGitHub",
"hoo29",
"kjin",
"ajafff",
"islishude",
"mwiktorczyk",
"mohsen1",
"n-e",
"galkin",
"parambirs",
"eps1lon",
"SimonSchick",
"ThomasdenH",
"WilcoBakker",
"wwwy3y3",
"samuela",
"kuehlein",
"bhongy",
"chyzwar",
"trivikr",
"nguymin4",
"yoursunny",
"qwelias",
"ExE-Boss",
"Ryan-Willpower",
"peterblazejewicz",
"addaleax",
"JasonHK",
"victorperin",
"ZYSzys",
"NodeJS",
"LinusU"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Critical"
},
{
"name": "parse",
"kind": "edit",
"files": [
{
"path": "types/parse/package.json",
"kind": "package-meta-ok"
},
{
"path": "types/parse/ts3.6/index.d.ts",
"kind": "definition"
},
{
"path": "types/parse/ts3.6/node.d.ts",
"kind": "definition"
},
{
"path": "types/parse/ts3.6/parse-tests.ts",
"kind": "test"
},
{
"path": "types/parse/ts3.6/react-native.d.ts",
"kind": "definition"
},
{
"path": "types/parse/ts3.6/tsconfig.json",
"kind": "package-meta-ok"
},
{
"path": "types/parse/ts3.6/tslint.json",
"kind": "package-meta-ok"
}
],
"owners": [
"ullisenmedia",
"dpoetzsch",
"jaeggerr",
"flavionegrao",
"wesleygrimes",
"owsas",
"agoldis",
"AlexandreHetu",
"dplewis",
"yomybaby",
"pocketcolin",
"rdhelms",
"jlnquere",
"tybi",
"RaschidJFR",
"jeffgukang",
"buitanloc",
"LinusU",
"JeromeDeLeon",
"kentrh",
"L3K0V",
"swittk"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Well-liked by everyone"
},
{
"name": "styled-components",
"kind": "edit",
"files": [
{
"path": "types/styled-components/package.json",
"kind": "package-meta-ok"
},
{
"path": "types/styled-components/ts3.6/cssprop.d.ts",
"kind": "definition"
},
{
"path": "types/styled-components/ts3.6/index.d.ts",
"kind": "definition"
},
{
"path": "types/styled-components/ts3.6/macro.d.ts",
"kind": "definition"
},
{
"path": "types/styled-components/ts3.6/test/index.tsx",
"kind": "test"
},
{
"path": "types/styled-components/ts3.6/test/macro.tsx",
"kind": "test"
},
{
"path": "types/styled-components/ts3.6/tsconfig.json",
"kind": "package-meta-ok"
},
{
"path": "types/styled-components/ts3.6/tslint.json",
"kind": "package-meta-ok"
}
],
"owners": [
"Igorbek",
"Igmat",
"lavoaster",
"Jessidhia",
"jkillian",
"eps1lon",
"flavordaaave",
"wagerfield",
"Lazyuki",
"mgoszcz2",
"danilofuchs"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Critical"
}
],
"reviews": [
{
"type": "approved",
"reviewer": "sandersn",
"date": "2021-08-25T23:25:14.000Z",
"isMaintainer": true
}
],
"mainBotCommentID": 890708479,
"ciResult": "pass"
} |
typescript-bot
added
Critical package
Edits multiple packages
Too Many Owners
Check Config
People who would have been pingednicoabie LinusU ExE-Boss yortus baxtersa marvinhagemeister bcherny martinheidegger jkeylu stripedpajamas sapfear bennett000 dtinth turadg Microsoft DefinitelyTyped jkomyno alvis r3nya btoueg smac89 touffy DeividasBakanas eyqs Hannes-Magnusson-CK KSXGitHub hoo29 kjin ajafff islishude mwiktorczyk mohsen1 n-e galkin parambirs eps1lon ThomasdenH WilcoBakker wwwy3y3 samuela kuehlein bhongy chyzwar trivikr nguymin4 yoursunny qwelias Ryan-Willpower peterblazejewicz addaleax JasonHK victorperin ZYSzys NodeJS ullisenmedia dpoetzsch jaeggerr flavionegrao wesleygrimes owsas agoldis AlexandreHetu dplewis yomybaby pocketcolin rdhelms jlnquere tybi RaschidJFR jeffgukang buitanloc JeromeDeLeon kentrh L3K0V swittk Igorbek Igmat lavoaster Jessidhia jkillian flavordaaave wagerfield Lazyuki mgoszcz2 danilofuchs |
|
@SimonSchick The CI build failed! Please review the logs for more information. Once you've pushed the fixes, the build will automatically re-run. Thanks! Note: builds which are failing do not end up on the list of PRs for the DT maintainers to review. |
|
I think this was a misstake, right? 😅 I tried looking thru the diff and couldn't find me being removed, maybe you already adressed this and the bot didn't update? |
|
@LinusU seems like a diffing but, don't know either way 🤷♂️ |
|
@SimonSchick Unfortunately, this pull request currently has a merge conflict 😥. Please update your PR branch to be up-to-date with respect to master. Have a nice day! |
typescript-bot
added
the
Has Merge Conflict
typescript-bot
removed
Has Merge Conflict
|
@SimonSchick The CI build failed! Please review the logs for more information. Once you've pushed the fixes, the build will automatically re-run. Thanks! Note: builds which are failing do not end up on the list of PRs for the DT maintainers to review. |
8 tasks
|
@sandersn we good to go? |
sandersn
approved these changes
Aug 25, 2021
typescript-bot
added
Maintainer Approved
Self Merge
|
@SimonSchick: Everything looks good here. I am ready to merge this PR (at 328163c) on your behalf whenever you think it's ready. If you'd like that to happen, please post a comment saying:
and I'll merge this PR almost instantly. Thanks for helping out! ❤️ |
|
Ready to merge |
|
I just published |
|
I just published |
|
I just published |
|
I just published |
|
I just published |
|
I just published |
|
I just published |
|
I just published |
|
I just published |
|
I just published |
retyui
added a commit
to retyui/DefinitelyTyped
that referenced
this pull request
Sep 13, 2021
17 tasks
elibarzilay
pushed a commit
that referenced
this pull request
Sep 13, 2021
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please fill in this template.
npm test <package to test>.Select one of these and delete the others:
If changing an existing definition:
This PR removes all ts3.6 support and folder in accordance of the support window.
I understand a similar structure might have to be implemented again should we want to integrate more modern features, but for the time being the focus is to shed this compability layer.
This PR also removed some duplicate WASI tests and dead comments in
node-tests.ts.