This repository has been archived by the owner on Apr 30, 2019. It is now read-only.
[Feature] Support for enterprise Github repository #223
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add an extra parameters in the tsd.json file to support specifying the url to your github host. Parameter name is githubHost and by default will point to github.com (so no change to current behavior). If an enterprise github url is specified instead then the url for requests will be adapted to follow the scheme of enterprise github.
Add a test, and make sure to support configuration that do not have the parameter
|
I'm not entirely sure why the travis CI build is failing on those API calls, the appveyor one does the same and works :/ |
|
Very nice! The tests has been fixed! I'll integrate this PR today! thanks! |
|
Well thank you ! |
Diullei
added a commit
that referenced
this pull request
Sep 26, 2015
[Feature] Support for enterprise Github repository
|
Do you think you could publish a new version on npm with this code ? :) |
|
Hi @nlunets! We'll add more features/fixes before next release. Thanks for this contribution :) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add an extra parameters in the tsd.json file to support specifying the url to your github host.
Parameter name is githubHost and by default will point to github.com (so no change to current behavior).
If an enterprise github url is specified instead then the url for requests will be adapted to follow the scheme of enterprise github.