Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move from y/N to yes/No for overwriting images #64

Open
wants to merge 21 commits into
base: main
Choose a base branch
from

Conversation

TheBlackKoala
Copy link
Contributor

No description provided.

Copy link
Contributor

@Chroxvi Chroxvi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally looks good!

Since this is really about making yes/no input consistent, I think we need to align your current changes with the way we ask the user to accept the Miniforge license, i.e.

I wonder if we are at the stage where we should refactor this code into a common utility function for handling such yes/no inputs. It is very likely that we are going to ask users for acceptance of other licenses or conditions in the future. What do you think?

cotainr/tests/pack/test_conda_install.py Outdated Show resolved Hide resolved
cotainr/pack.py Outdated Show resolved Hide resolved
cotainr/util.py Show resolved Hide resolved
cotainr/util.py Outdated Show resolved Hide resolved
cotainr/util.py Outdated Show resolved Hide resolved
TheBlackKoala and others added 4 commits September 6, 2024 12:41
Co-authored-by: Aarni Koskela <akx@iki.fi>
…ock_factory to handle more than one input and change name of answer_yes
cotainr/pack.py Outdated Show resolved Hide resolved
cotainr/cli.py Outdated Show resolved Hide resolved
cotainr/tests/conftest.py Outdated Show resolved Hide resolved
cotainr/tests/pack/test_conda_install.py Outdated Show resolved Hide resolved
cotainr/tests/util/test_answer_is_yes.py Outdated Show resolved Hide resolved
cotainr/tests/util/test_answer_is_yes.py Outdated Show resolved Hide resolved
cotainr/tests/util/test_answer_is_yes.py Outdated Show resolved Hide resolved
cotainr/tests/util/test_answer_is_yes.py Outdated Show resolved Hide resolved
cotainr/util.py Outdated Show resolved Hide resolved
cotainr/tests/conftest.py Outdated Show resolved Hide resolved
.gitignore Show resolved Hide resolved
cotainr/cli.py Outdated Show resolved Hide resolved
TheBlackKoala and others added 2 commits September 13, 2024 10:38
Co-authored-by: Aarni Koskela <akx@iki.fi>
@Chroxvi Chroxvi added bug Something isn't working enhancement New feature or request labels Oct 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants