-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move from y/N to yes/No for overwriting images #64
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally looks good!
Since this is really about making yes/no input consistent, I think we need to align your current changes with the way we ask the user to accept the Miniforge license, i.e.
- Also rename
val
toanswer
inLine 264 in 4763532
val = input(license_text) # prompt user for acceptance of license terms .lower()
to the it. - Add a parametrized test case of "Yes" (in addition to "yes") to
monkeypatch.setattr("builtins.input", factory_mock_input("yes"))
I wonder if we are at the stage where we should refactor this code into a common utility function for handling such yes/no inputs. It is very likely that we are going to ask users for acceptance of other licenses or conditions in the future. What do you think?
Co-authored-by: Aarni Koskela <akx@iki.fi>
…ock_factory to handle more than one input and change name of answer_yes
Co-authored-by: Aarni Koskela <akx@iki.fi>
No description provided.