Added pending jobs handling API to Runtime #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DelSkayn
requested changes
Nov 13, 2020
| /// Execute first pending job | ||
| /// | ||
| /// Returns context for executed job or none when queue is empty or error when exception thrown under execution. | ||
| pub fn execute_pending_job(&self) -> Result<Option<Ctx<'_>>, Error> { |
There was a problem hiding this comment.
Ctx should not be available outside a callback handed to Context::with otherwise the runtime can be accessed outside the mutex guard, which is unsafe.
There was a problem hiding this comment.
This functions should probably be a member of Ctx.
There was a problem hiding this comment.
By design QuickJS has single queue per runtime, so this function cannot be member of Ctx.
There was a problem hiding this comment.
My next pr #6 supersede this, I already changed returning value.
|
Closed, resolved in later pull request |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added missing APIs to execute pending jobs in queue.
This is required for handling async stuff like promises and generators.