Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow list of rotation conditions in file rotation logic #1175

Merged
merged 4 commits into from
Jan 17, 2025

Conversation

CollinHeist
Copy link
Contributor

This implements the behavior described in #1174 , and allows for specification of a list (or tuple/set) of conditions for file rotation, like so:

from loguru import logger

logger.configure(
  handlers=[
    dict(
      sink='file.log',
      rotation=['12h', '10 MB'],
    )
  ]
)

@Delgan
Copy link
Owner

Delgan commented Oct 5, 2024

Thanks for your PR @CollinHeist. Apologies for the delay.

Admittedly, I was initially rather reluctant to add such a feature, for the sake of simplicity. Though, I agree that this is not actually very cumbersome to add, and indeed, and it can visibly be useful to several users.

Just to let you know that I haven't forgotten the PR and plan to merge it after releasing a new debug release. Thank you again for your work.

@Delgan Delgan merged commit b64e1d5 into Delgan:master Jan 17, 2025
20 checks passed
@Delgan
Copy link
Owner

Delgan commented Jan 17, 2025

Merged, thanks for your patience!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants