Refactor pretty exception formatting #76
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is done for several reasons: * Avoid the need of maintaining a second package * Allow changes to Loguru to be made faster * More freedom about exception formatting * Prevent my biaised opinion to bother "better_exceptions" maintainer * Half of "better_exceptions" implementation isn't useful to Loguru (repl, cmd, color support checks, hook, logging, encoding) * Remove the risk of conflict between the two packages * Avoid addind the ".pth" file for "better_exceptions" while installing Loguru * I know the "better_exceptions" codebase well enough (and it's quite simple) * One less dependency is always welcome
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A bunch of changes made to the exception formatting, including: replacing
better_exceptions(_fork)library with a new_better_exceptions.pymodule, separating exception formatting / extending with newdiagnoseoption in addition tobacktrace(#49), making some fixes (#50, #52, Windows colors and others edge cases).