Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update ⬆️ gomod to v0.17.0 - autoclosed #121

Conversation

mend-for-github-com[bot]
Copy link
Contributor

@mend-for-github-com mend-for-github-com bot commented Dec 21, 2023

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
golang.org/x/crypto v0.12.0 -> v0.17.0 age adoption passing confidence

Warning

Some dependencies could not be looked up. Check the Dependency Dashboard for more information.

GitHub Vulnerability Alerts

CVE-2023-48795

Summary

Terrapin is a prefix truncation attack targeting the SSH protocol. More precisely, Terrapin breaks the integrity of SSH's secure channel. By carefully adjusting the sequence numbers during the handshake, an attacker can remove an arbitrary amount of messages sent by the client or server at the beginning of the secure channel without the client or server noticing it.

Mitigations

To mitigate this protocol vulnerability, OpenSSH suggested a so-called "strict kex" which alters the SSH handshake to ensure a Man-in-the-Middle attacker cannot introduce unauthenticated messages as well as convey sequence number manipulation across handshakes.

Warning: To take effect, both the client and server must support this countermeasure.

As a stop-gap measure, peers may also (temporarily) disable the affected algorithms and use unaffected alternatives like AES-GCM instead until patches are available.

Details

The SSH specifications of ChaCha20-Poly1305 (chacha20-poly1305@​openssh.com) and Encrypt-then-MAC (*-etm@openssh.com MACs) are vulnerable against an arbitrary prefix truncation attack (a.k.a. Terrapin attack). This allows for an extension negotiation downgrade by stripping the SSH_MSG_EXT_INFO sent after the first message after SSH_MSG_NEWKEYS, downgrading security, and disabling attack countermeasures in some versions of OpenSSH. When targeting Encrypt-then-MAC, this attack requires the use of a CBC cipher to be practically exploitable due to the internal workings of the cipher mode. Additionally, this novel attack technique can be used to exploit previously unexploitable implementation flaws in a Man-in-the-Middle scenario.

The attack works by an attacker injecting an arbitrary number of SSH_MSG_IGNORE messages during the initial key exchange and consequently removing the same number of messages just after the initial key exchange has concluded. This is possible due to missing authentication of the excess SSH_MSG_IGNORE messages and the fact that the implicit sequence numbers used within the SSH protocol are only checked after the initial key exchange.

In the case of ChaCha20-Poly1305, the attack is guaranteed to work on every connection as this cipher does not maintain an internal state other than the message's sequence number. In the case of Encrypt-Then-MAC, practical exploitation requires the use of a CBC cipher; while theoretical integrity is broken for all ciphers when using this mode, message processing will fail at the application layer for CTR and stream ciphers.

For more details see https://terrapin-attack.com.

Impact

This attack targets the specification of ChaCha20-Poly1305 (chacha20-poly1305@​openssh.com) and Encrypt-then-MAC (*-etm@openssh.com), which are widely adopted by well-known SSH implementations and can be considered de-facto standard. These algorithms can be practically exploited; however, in the case of Encrypt-Then-MAC, we additionally require the use of a CBC cipher. As a consequence, this attack works against all well-behaving SSH implementations supporting either of those algorithms and can be used to downgrade (but not fully strip) connection security in case SSH extension negotiation (RFC8308) is supported. The attack may also enable attackers to exploit certain implementation flaws in a man-in-the-middle (MitM) scenario.


Configuration

📅 Schedule: Branch creation - "" (UTC), Automerge - At any time (no schedule defined).

🚦 Automerge: Enabled.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.


  • If you want to rebase/retry this PR, check this box

Copy link

codecov bot commented Dec 21, 2023

Codecov Report

Attention: 449 lines in your changes are missing coverage. Please review.

Comparison is base (a2521eb) 32.61% compared to head (29fc488) 44.88%.
Report is 74 commits behind head on main.

Files Patch % Lines
commands/siem.go 0.00% 68 Missing ⚠️
internal/store/secure_store.go 0.00% 52 Missing ⚠️
internal/store/credential-helpers/pass.go 8.51% 43 Missing ⚠️
tests/fake/fake_store.go 15.21% 39 Missing ⚠️
commands/base.go 6.45% 29 Missing ⚠️
commands/byok.go 64.38% 26 Missing ⚠️
commands/engine.go 31.57% 26 Missing ⚠️
internal/store/file_store.go 56.89% 19 Missing and 6 partials ⚠️
commands/pool.go 25.00% 21 Missing ⚠️
commands/user.go 75.29% 18 Missing and 3 partials ⚠️
... and 14 more
Additional details and impacted files
@@             Coverage Diff             @@
##             main     #121       +/-   ##
===========================================
+ Coverage   32.61%   44.88%   +12.27%     
===========================================
  Files          80       86        +6     
  Lines       10855    11880     +1025     
===========================================
+ Hits         3540     5332     +1792     
+ Misses       7027     6329      -698     
+ Partials      288      219       -69     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mend-for-github-com mend-for-github-com bot force-pushed the whitesource-remediate/go-golang.org/x/crypto-vulnerability branch 6 times, most recently from c31da1d to c51fc97 Compare December 22, 2023 11:14
@mend-for-github-com mend-for-github-com bot force-pushed the whitesource-remediate/go-golang.org/x/crypto-vulnerability branch from c51fc97 to 29fc488 Compare December 22, 2023 11:19
@mend-for-github-com mend-for-github-com bot changed the title chore(deps): update ⬆️ gomod to v0.17.0 chore(deps): update ⬆️ gomod to v0.17.0 - autoclosed Jan 10, 2024
auto-merge was automatically disabled January 10, 2024 16:35

Pull request was closed

@mend-for-github-com mend-for-github-com bot deleted the whitesource-remediate/go-golang.org/x/crypto-vulnerability branch January 10, 2024 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

0 participants